Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 23611005: ash: Allow web pages to use the Ctrl-M minimize shortcut (Closed)

Created:
7 years, 3 months ago by James Cook
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, tfarina, mazda+watch_chromium.org
Visibility:
Public.

Description

ash: Allow web pages to use the Ctrl-M minimize shortcut The active window is minimized only if the active web page or app does not handle the key first. BUG=284522 TEST=manual, ash_unittests AcceleratorCommandsTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221294

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -19 lines) Patch
A ash/accelerators/accelerator_commands.h View 1 chunk +23 lines, -0 lines 1 comment Download
A ash/accelerators/accelerator_commands.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A ash/accelerators/accelerator_commands_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 2 chunks +3 lines, -17 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +26 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/ash.gyp View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
sky, PTAL And thanks for your advice this morning. https://codereview.chromium.org/23611005/diff/1/ash/accelerators/accelerator_commands.h File ash/accelerators/accelerator_commands.h (right): https://codereview.chromium.org/23611005/diff/1/ash/accelerators/accelerator_commands.h#newcode1 ash/accelerators/accelerator_commands.h:1: ...
7 years, 3 months ago (2013-09-04 17:58:06 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-04 20:26:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/23611005/1
7 years, 3 months ago (2013-09-04 20:28:34 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 23:31:35 UTC) #4
Message was sent while issue was closed.
Change committed as 221294

Powered by Google App Engine
This is Rietveld 408576698