Issue 23610004: Rename managed user pref store to supervised user pref store.

Issue 23610004: Rename managed user pref store to supervised user pref store. (Closed)

Created:
7 years, 3 months ago by Bernhard Bauer

Modified:
7 years, 3 months ago

Reviewers:
bartfab (slow), Paweł Hajdan Jr.

CC:
chromium-reviews, erikwright+watch_chromium.org, Mattias Nissler (ping if slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename managed user prefs to supervised user prefs. Also, update comment for the PrefValueStore constructor. TBR=phajdan.jr@chromium.org BUG=280674 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220385

Patch Set 3 : fix #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -72 lines)			Patch
M	base/prefs/pref_service_builder.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/prefs/pref_service_builder.cc	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download
M	base/prefs/pref_value_store.h	View	1	5 chunks	+7 lines, -4 lines	0 comments	Download
M	base/prefs/pref_value_store.cc	View	1 2	5 chunks	+6 lines, -6 lines	0 comments	Download
M	base/prefs/pref_value_store_unittest.cc	View	1	26 chunks	+54 lines, -53 lines	0 comments	Download
M	chrome/browser/prefs/pref_service_syncable.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/pref_service_syncable_builder.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/base/testing_pref_service_syncable.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bartfab (slow)

Two lines got swapped around. Other than that, lgtm. https://codereview.chromium.org/23610004/diff/3001/base/prefs/pref_value_store.cc File base/prefs/pref_value_store.cc (right): https://codereview.chromium.org/23610004/diff/3001/base/prefs/pref_value_store.cc#newcode84 base/prefs/pref_value_store.cc:84: ...

7 years, 3 months ago (2013-08-29 13:47:39 UTC) #2

Bernhard Bauer

Paweł: Yet Another TBR spam :) https://codereview.chromium.org/23610004/diff/3001/base/prefs/pref_value_store.cc File base/prefs/pref_value_store.cc (right): https://codereview.chromium.org/23610004/diff/3001/base/prefs/pref_value_store.cc#newcode84 base/prefs/pref_value_store.cc:84: supervised_user_prefs = GetPrefStore(SUPERVISED_USER_STORE); ...

7 years, 3 months ago (2013-08-29 13:54:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/23610004/12001

7 years, 3 months ago (2013-08-29 13:54:45 UTC) #4

Message was sent while issue was closed.

Change committed as 220385

Expand Messages | Collapse Messages