[Android WebView] Use bitmap fonts

[Android WebView] Match chrome font settings

Code is duplicated from //chrome.

BUG=291745
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223271

[boliu, 2013-09-14 00:19:54]

For internal b/10748390, but this is a "I have no idea what I'm doing" patch.

This setting is passed into:
RenderViewImpl::UpdateFontRenderingFromRendererPrefs
WebFontRendering::setUseBitmaps
FontPlatformData::setUseBitmaps

Eventually the value is used for paint->setEmbeddedBitmapText, which sets the
kEmbeddedBitmapText_Flag

That was a log of grepping...

[boliu, 2013-09-14 00:22:10]

On 2013/09/14 00:19:54, boliu wrote:
> For internal b/10748390, but this is a "I have no idea what I'm doing" patch.
> 
> This setting is passed into:
> RenderViewImpl::UpdateFontRenderingFromRendererPrefs
> WebFontRendering::setUseBitmaps
> FontPlatformData::setUseBitmaps
> 
> Eventually the value is used for paint->setEmbeddedBitmapText, which sets the
> kEmbeddedBitmapText_Flag
> 
> That was a log of grepping...

Also no idea how to test this...

[boliu, 2013-09-14 00:33:23]

On 2013/09/14 00:22:10, boliu wrote:
> On 2013/09/14 00:19:54, boliu wrote:
> > For internal b/10748390, but this is a "I have no idea what I'm doing"
patch.
> > 
> > This setting is passed into:
> > RenderViewImpl::UpdateFontRenderingFromRendererPrefs
> > WebFontRendering::setUseBitmaps
> > FontPlatformData::setUseBitmaps
> > 
> > Eventually the value is used for paint->setEmbeddedBitmapText, which sets
the
> > kEmbeddedBitmapText_Flag
> > 
> > That was a log of grepping...
> 
> Also no idea how to test this...

And more grepping showed me GetDefaultWebKitFontRenderParams, which does all the
right things on android. New patch coming.

[benm (inactive), 2013-09-14 03:46:26]

https://codereview.chromium.org/23609051/diff/8001/android_webview/native/aw_...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/23609051/diff/8001/android_webview/native/aw_...
android_webview/native/aw_contents.cc:269: prefs->hinting =
GetRendererPreferencesHintingEnum(params.hinting);
you are overwriting the hinting pref we set on line 261, this will break font
rendering I think? Or is SLIGHT the default?

Do we need to set all these prefs to get the desired effect?

[boliu, 2013-09-14 04:46:52]

So it's a judgement call.

I think we should not differ from chrome on android for no good reason (and the
reason before is we didn't know about it)

If you don't agree, we can go back to the one line PS1.

https://codereview.chromium.org/23609051/diff/8001/android_webview/native/aw_...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/23609051/diff/8001/android_webview/native/aw_...
android_webview/native/aw_contents.cc:269: prefs->hinting =
GetRendererPreferencesHintingEnum(params.hinting);
On 2013/09/14 03:46:26, benm wrote:
> you are overwriting the hinting pref we set on line 261, this will break font
> rendering I think? Or is SLIGHT the default?

Nope, NONE is the default. Changed back.

> 
> Do we need to set all these prefs to get the desired effect?

No, pretty sure only need use_bitmaps.

[benm (inactive), 2013-09-14 18:26:24]

thanks Bo - I will verify the cases that were broken that caused us to introduce
the first set of render params are still OK (or better!) with this patch and let
you know.

cheers

https://codereview.chromium.org/23609051/diff/13001/android_webview/native/aw...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/23609051/diff/13001/android_webview/native/aw...
android_webview/native/aw_contents.cc:255: prefs->hinting =
content::RENDERER_PREFERENCES_HINTING_SLIGHT;
actually - it looks like the default on android is to use slight... see
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/font_render...

[boliu, 2013-09-14 18:35:00]

https://codereview.chromium.org/23609051/diff/13001/android_webview/native/aw...
File android_webview/native/aw_contents.cc (right):

https://codereview.chromium.org/23609051/diff/13001/android_webview/native/aw...
android_webview/native/aw_contents.cc:255: prefs->hinting =
content::RENDERER_PREFERENCES_HINTING_SLIGHT;
On 2013/09/14 18:26:24, benm wrote:
> actually - it looks like the default on android is to use slight... see
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/font_render...

Bah, misread again, was looking at SUBPIXEL_RENDERING_NONE. I blame coding on
Friday night....

[benm (inactive), 2013-09-14 22:11:34]

lgtm

Thanks Bo!

[benm (inactive), 2013-09-14 22:11:53]

On 2013/09/14 22:11:34, benm wrote:
> lgtm
> 
> Thanks Bo!

nit: maybe file a bug for the de-duping

[boliu, 2013-09-14 22:14:59]

On 2013/09/14 22:11:53, benm wrote:
> On 2013/09/14 22:11:34, benm wrote:
> > lgtm
> > 
> > Thanks Bo!
> 
> nit: maybe file a bug for the de-duping

Filed crbug.com/291745

[commit-bot: I haz the power, 2013-09-14 22:15:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/23609051/18001

[commit-bot: I haz the power, 2013-09-15 00:43:44]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-09-15 01:26:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/23609051/18001

[commit-bot: I haz the power, 2013-09-15 03:37:58]

Change committed as 223271