Issue 23608007: Remove drive::DriveAppRegistry::DriveAppFileSelector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23608007: Remove drive::DriveAppRegistry::DriveAppFileSelector. (Closed)

Created:
7 years, 3 months ago by kinaba

Modified:
7 years, 3 months ago

Reviewers:
satorux1

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove drive::DriveAppRegistry::DriveAppFileSelector. The struct was used for keeping the app list internally in DriveAppRegistry, but the information it holds is identical to its public cousin: DriveAppInfo. BUG=284951 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221210

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -119 lines)			Patch
	M	chrome/browser/chromeos/drive/drive_app_registry.h	View	1	4 chunks	+5 lines, -40 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/drive_app_registry.cc	View	1	10 chunks	+31 lines, -79 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/23608007/6001

7 years, 3 months ago (2013-09-04 06:23:27 UTC) #3

Message was sent while issue was closed.

Change committed as 221210

Expand Messages | Collapse Messages