Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5238)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 23608003: Default keyboard layout should be set considering owners preference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | chromeos/ime/input_method_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
index cd578b63994a637190a45b1886693680a89dd329..d77856f452ef696c73b620607f04b893bcdb4479 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
@@ -1018,21 +1018,11 @@ void SigninScreenHandler::OnDnsCleared() {
ShowSigninScreenIfReady();
}
-void SigninScreenHandler::SetUserInputMethodHWDefault() {
- chromeos::input_method::InputMethodManager* manager =
- chromeos::input_method::InputMethodManager::Get();
- manager->ChangeInputMethod(
- manager->GetInputMethodUtil()->GetHardwareInputMethodId());
-}
-
// Update keyboard layout to least recently used by the user.
void SigninScreenHandler::SetUserInputMethod(const std::string& username) {
chromeos::input_method::InputMethodManager* const manager =
chromeos::input_method::InputMethodManager::Get();
- const chromeos::input_method::InputMethodUtil& ime_util =
- *manager->GetInputMethodUtil();
-
const bool succeed = SetUserInputMethodImpl(username, manager);
// This is also a case when LRU layout is set only for a few local users,
@@ -1040,10 +1030,9 @@ void SigninScreenHandler::SetUserInputMethod(const std::string& username) {
// Otherwise they will end up using another user's locale to log in.
if (!succeed) {
DLOG(INFO) << "SetUserInputMethod('" << username
- << "'): failed to set user layout. Switching to default '"
- << ime_util.GetHardwareInputMethodId() << "'";
+ << "'): failed to set user layout. Switching to default.";
- SetUserInputMethodHWDefault();
+ manager->SetInputMethodDefault();
}
}
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | chromeos/ime/input_method_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698