Issue 23606018: drive: Move some of FileSystemTest tests to lower layers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23606018: drive: Move some of FileSystemTest tests to lower layers. (Closed)

Created:
7 years, 3 months ago by kinaba

Modified:
7 years, 3 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Move some of FileSystemTest tests to lower layers. * Base name duplication is handled and should be tested in ResourceMetadata. * OpenFile's behavior can be tested in OpenFileOperation. Along the way did some clean up. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221659

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -152 lines)			Patch
M	chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc	View	3 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_unittest.cc	View	8 chunks	+5 lines, -144 lines	0 comments	Download
M	chrome/browser/chromeos/drive/resource_metadata_unittest.cc	View	3 chunks	+119 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/23606018/1

7 years, 3 months ago (2013-09-06 06:54:58 UTC) #3

Message was sent while issue was closed.

Change committed as 221659

Expand Messages | Collapse Messages