Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2511)

Unified Diff: ash/launcher/app_list_launcher_item_delegate.h

Issue 23606016: Refactor LauncherItemController and LauncherItemDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix for LauncherTest and observing LauncherModel in DelegateManager Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/launcher/app_list_launcher_item_delegate.h
diff --git a/ash/launcher/app_list_launcher_item_delegate.h b/ash/launcher/app_list_launcher_item_delegate.h
index 6452c6e8e260a13c5a3a8a1a04d2ea720c34840e..10043d728c0d7fffec00996a2b58ce997a7a05e0 100644
--- a/ash/launcher/app_list_launcher_item_delegate.h
+++ b/ash/launcher/app_list_launcher_item_delegate.h
@@ -12,7 +12,8 @@
namespace ash {
namespace internal {
-// LauncherItemDelegate for TYPE_APP_LIST.
+// LauncherItemDelegate for TYPE_APP_LIST. Life-cycle of this class is handled
sky 2013/09/11 01:42:57 nit: life-cycle... -> Owned by LauncherItemDelegat
simonhong_ 2013/09/11 09:05:26 Done.
+// by LauncherItemDelegateManager.
class AppListLauncherItemDelegate : public LauncherItemDelegate {
public:
AppListLauncherItemDelegate();
@@ -20,17 +21,13 @@ class AppListLauncherItemDelegate : public LauncherItemDelegate {
virtual ~AppListLauncherItemDelegate();
// ash::LauncherItemDelegate overrides:
- virtual void ItemSelected(const LauncherItem& item,
- const ui::Event& event) OVERRIDE;
- virtual base::string16 GetTitle(const LauncherItem& item) OVERRIDE;
+ virtual void ItemSelected(const ui::Event& event) OVERRIDE;
+ virtual base::string16 GetTitle() OVERRIDE;
virtual ui::MenuModel* CreateContextMenu(
- const LauncherItem& item,
aura::RootWindow* root_window) OVERRIDE;
- virtual LauncherMenuModel* CreateApplicationMenu(
- const LauncherItem& item,
- int event_flags) OVERRIDE;
- virtual bool IsDraggable(const LauncherItem& item) OVERRIDE;
- virtual bool ShouldShowTooltip(const LauncherItem& item) OVERRIDE;
+ virtual LauncherMenuModel* CreateApplicationMenu(int event_flags) OVERRIDE;
+ virtual bool IsDraggable() OVERRIDE;
+ virtual bool ShouldShowTooltip() OVERRIDE;
private:
DISALLOW_COPY_AND_ASSIGN(AppListLauncherItemDelegate);

Powered by Google App Engine
This is Rietveld 408576698