Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 23604061: Set the printer info in crash reports using the crash key logging system. (Closed)

Created:
7 years, 3 months ago by Robert Sesek
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix memory issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -137 lines) Patch
M chrome/app/breakpad_linux.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/app/breakpad_win.cc View 3 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/printing/print_system_task_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/child_process_logging.h View 4 chunks +0 lines, -27 lines 0 comments Download
M chrome/common/child_process_logging_mac.mm View 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/common/child_process_logging_posix.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/common/child_process_logging_win.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/common/crash_keys.h View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 4 chunks +37 lines, -0 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
7 years, 3 months ago (2013-09-16 19:29:25 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 3 months ago (2013-09-17 08:39:53 UTC) #2
Robert Sesek
Committed patchset #1 manually as r223610 (presubmit successful).
7 years, 3 months ago (2013-09-17 13:59:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/23604061/10001
7 years, 3 months ago (2013-09-17 15:19:44 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 18:27:05 UTC) #5
Message was sent while issue was closed.
Change committed as 223641

Powered by Google App Engine
This is Rietveld 408576698