Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 23604055: [OSX] Turn on canvas_skia for OSX (Closed)

Created:
7 years, 3 months ago by groby-ooo-7-16
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[OSX] Turn on canvas_skia for OSX Re-submit of r222192, with fixed tests. R=asvitkine@chromium.org BUG=151935 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223202

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -93 lines) Patch
build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
ui/gfx/canvas_mac.mm View 1 chunk +0 lines, -90 lines 0 comments Download
ui/gfx/canvas_unittest_mac.mm View 1 chunk +82 lines, -0 lines 2 comments Download
ui/ui.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
ui/ui_unittests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
PTAL: Trying once more, this time with a test that runs in debug, too. (Still ...
7 years, 3 months ago (2013-09-12 23:20:32 UTC) #1
Alexei Svitkine (slow)
I think it only uses the _rel bots which don't have dchecks enabled. It's quite ...
7 years, 3 months ago (2013-09-13 02:05:54 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/23604055/diff/1/ui/gfx/canvas_unittest_mac.mm File ui/gfx/canvas_unittest_mac.mm (right): https://codereview.chromium.org/23604055/diff/1/ui/gfx/canvas_unittest_mac.mm#newcode54 ui/gfx/canvas_unittest_mac.mm:54: int mac_width = kReallyLargeNumber; Just pass in 0 instead.
7 years, 3 months ago (2013-09-13 02:06:36 UTC) #3
groby-ooo-7-16
https://codereview.chromium.org/23604055/diff/1/ui/gfx/canvas_unittest_mac.mm File ui/gfx/canvas_unittest_mac.mm (right): https://codereview.chromium.org/23604055/diff/1/ui/gfx/canvas_unittest_mac.mm#newcode54 ui/gfx/canvas_unittest_mac.mm:54: int mac_width = kReallyLargeNumber; I do this deliberately to ...
7 years, 3 months ago (2013-09-13 18:09:07 UTC) #4
Alexei Svitkine (slow)
Okay, LGTM
7 years, 3 months ago (2013-09-13 18:11:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/23604055/1
7 years, 3 months ago (2013-09-13 19:10:20 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-14 01:32:18 UTC) #7
Message was sent while issue was closed.
Change committed as 223202

Powered by Google App Engine
This is Rietveld 408576698