Implement Composition interface for IME API

Implement Composition interface for IME API

Spec: http://www.w3.org/TR/ime-api/#composition-interface
This interface represents an ongoing IME composition. It provides attributes
representing the text being composed by an IME and its associated information.

The interface IDL is already committed at r155072.
This CL implements the interface.

BUG=238585
TEST=layouttest fast/ime

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157593

[kochi, 2013-09-11 07:47:26]

tkent-san,

Could you review?

Thanks,

[tkent, 2013-09-11 08:10:55]

https://chromiumcodereview.appspot.com/23604053/diff/4001/Source/core/html/im...
File Source/core/html/ime/InputMethodContext.cpp (right):

https://chromiumcodereview.appspot.com/23604053/diff/4001/Source/core/html/im...
Source/core/html/ime/InputMethodContext.cpp:76:
m_element->document().frame()->inputMethodController().confirmCompositionAndResetState();
nit: We had better have a helper function to get an InputMethodController.

https://chromiumcodereview.appspot.com/23604053/diff/4001/Source/core/html/im...
File Source/core/html/ime/InputMethodContext.h (right):

https://chromiumcodereview.appspot.com/23604053/diff/4001/Source/core/html/im...
Source/core/html/ime/InputMethodContext.h:61: String getCompositionText() const;
Do not add "get" prefix for getter functions.

See 6 of http://www.chromium.org/blink/coding-style#TOC-Names

[kochi, 2013-09-11 08:31:59]

Thanks for the review!

https://chromiumcodereview.appspot.com/23604053/diff/4001/Source/core/html/im...
File Source/core/html/ime/InputMethodContext.cpp (right):

https://chromiumcodereview.appspot.com/23604053/diff/4001/Source/core/html/im...
Source/core/html/ime/InputMethodContext.cpp:76:
m_element->document().frame()->inputMethodController().confirmCompositionAndResetState();
On 2013/09/11 08:10:55, tkent wrote:
> nit: We had better have a helper function to get an InputMethodController.

Done.

Added inputMethodController() helper function.

https://chromiumcodereview.appspot.com/23604053/diff/4001/Source/core/html/im...
File Source/core/html/ime/InputMethodContext.h (right):

https://chromiumcodereview.appspot.com/23604053/diff/4001/Source/core/html/im...
Source/core/html/ime/InputMethodContext.h:61: String getCompositionText() const;
On 2013/09/11 08:10:55, tkent wrote:
> Do not add "get" prefix for getter functions.
> 
> See 6 of http://www.chromium.org/blink/coding-style#TOC-Names

Done.

[tkent, 2013-09-11 08:39:03]

lgtm

https://chromiumcodereview.appspot.com/23604053/diff/8001/LayoutTests/fast/im...
File LayoutTests/fast/ime/inputmethodcontext-composition.html (right):

https://chromiumcodereview.appspot.com/23604053/diff/8001/LayoutTests/fast/im...
LayoutTests/fast/ime/inputmethodcontext-composition.html:8: description("This
tests composition attribute of InputMethodContext.");
nit: please have consistent usage of quotation marks.  You use ' in many lines,
but sometime use ".

[kochi, 2013-09-11 08:53:41]

Thanks for the review!

https://codereview.chromium.org/23604053/diff/8001/LayoutTests/fast/ime/input...
File LayoutTests/fast/ime/inputmethodcontext-composition.html (right):

https://codereview.chromium.org/23604053/diff/8001/LayoutTests/fast/ime/input...
LayoutTests/fast/ime/inputmethodcontext-composition.html:8: description("This
tests composition attribute of InputMethodContext.");
On 2013/09/11 08:39:04, tkent wrote:
> nit: please have consistent usage of quotation marks.  You use ' in many
lines,
> but sometime use ".

Done.

[commit-bot: I haz the power, 2013-09-11 08:54:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/23604053/16001

[commit-bot: I haz the power, 2013-09-11 10:00:31]

Change committed as 157593