Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 23604046: [rAC, OSX] Add title to OSX rAC dialog. (Closed)

Created:
7 years, 3 months ago by groby-ooo-7-16
Modified:
7 years, 3 months ago
Reviewers:
Ilya Sherman, sail
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Simplify baseline computation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm View 1 3 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
7 years, 3 months ago (2013-09-06 22:21:14 UTC) #1
Ilya Sherman
LGTM, but I think you might want to ask someone with more Cocoa familiarity to ...
7 years, 3 months ago (2013-09-06 23:09:04 UTC) #2
groby-ooo-7-16
Realized I can _somewhat_ simplify this, added sail as reviewer for font size computation sanity ...
7 years, 3 months ago (2013-09-09 21:53:51 UTC) #3
sail
lgtm, just hard coding an offset is ok too. We do this for the omnibox.
7 years, 3 months ago (2013-09-09 22:48:33 UTC) #4
groby-ooo-7-16
sail: I'm not trusting the font size is final :)
7 years, 3 months ago (2013-09-09 23:02:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/23604046/5001
7 years, 3 months ago (2013-09-09 23:03:55 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 08:47:49 UTC) #7
Message was sent while issue was closed.
Change committed as 222222

Powered by Google App Engine
This is Rietveld 408576698