Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 23604037: Recompute percentage based @viewport on resize. (Closed)

Created:
7 years, 3 months ago by rune
Modified:
7 years, 3 months ago
CC:
blink-reviews, kenneth.christiansen, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Recompute percentage based @viewport on resize. Percentage values were resolved to px lengths at cascade time for @viewport widths and heights. This change keeps them as percentage values and recompute the actual viewport from the initial viewport and the percentage value when the intial viewport changes (window resize). Likewise for viewport relative units (vw, vh, vmin, vmax). This fixes constrain-006 and constrain-007 in the w3c testsuite. This CL also disallows 'initial' and 'inherit' as descriptor values and returns 'auto' for unknown non-primitive values to avoid crashers and improve on the original CL for the same bug: https://codereview.chromium.org/22549002/ BUG=269132 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157225

Patch Set 1 #

Patch Set 2 : Don't allow inherit or initial in viewport descriptors #

Total comments: 2

Patch Set 3 : Fixed review issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -49 lines) Patch
M LayoutTests/css3/device-adapt/opera/constrain-006-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/css3/device-adapt/opera/constrain-007-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/css3/device-adapt/viewport-invalid-values-001.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/css3/device-adapt/viewport-invalid-values-001-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/resolver/ViewportStyleResolver.cpp View 1 2 4 chunks +44 lines, -16 lines 0 comments Download
M Source/core/dom/ViewportArguments.h View 4 chunks +9 lines, -8 lines 0 comments Download
M Source/core/dom/ViewportArguments.cpp View 3 chunks +32 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rune
Patch Set 1 should be identical to the reverted CL. Patch Set 2 contains the ...
7 years, 3 months ago (2013-09-03 22:14:22 UTC) #1
kenneth.r.christiansen
lgtm
7 years, 3 months ago (2013-09-04 10:57:51 UTC) #2
darktears
On 2013/09/04 10:57:51, kenneth.r.christiansen wrote: > lgtm lgtm
7 years, 3 months ago (2013-09-04 11:05:52 UTC) #3
esprehn
btw you can't TBR functional changes like this. I think you wanted R=. https://codereview.chromium.org/23604037/diff/3001/Source/core/css/resolver/ViewportStyleResolver.cpp File ...
7 years, 3 months ago (2013-09-04 11:22:24 UTC) #4
rune
https://codereview.chromium.org/23604037/diff/3001/Source/core/css/resolver/ViewportStyleResolver.cpp File Source/core/css/resolver/ViewportStyleResolver.cpp (right): https://codereview.chromium.org/23604037/diff/3001/Source/core/css/resolver/ViewportStyleResolver.cpp#newcode164 Source/core/css/resolver/ViewportStyleResolver.cpp:164: Length ViewportStyleResolver::getViewportLengthValue(CSSPropertyID id) const On 2013/09/04 11:22:24, esprehn wrote: ...
7 years, 3 months ago (2013-09-04 14:53:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23604037/13001
7 years, 3 months ago (2013-09-04 14:58:02 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 17:45:17 UTC) #7
Message was sent while issue was closed.
Change committed as 157225

Powered by Google App Engine
This is Rietveld 408576698