ASSERT: Bad cast from CSSInitialValue to CSSValueList

ASSERT: Bad cast from CSSInitialValue to CSSValueList

The issue was that we would cast to CSSValueList without checking
the type of the CSSValue. After this change, we use the ASSERT'ing
cast and explicitly check the type of the CSSValue before the cast.

BUG=279286
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157255

[eseidel, 2013-09-03 22:40:23]

looks like a leak.  not lgtm

https://codereview.chromium.org/23604036/diff/1/Source/core/css/CSSParser-in.cpp
File Source/core/css/CSSParser-in.cpp (right):

https://codereview.chromium.org/23604036/diff/1/Source/core/css/CSSParser-in....
Source/core/css/CSSParser-in.cpp:1156: return
toCSSValueList(dummyStyle->getPropertyCSSValue(CSSPropertyFontFamily).leakRef());
leakRef?  You mean release and static_ptr_cast?

[Julien - ping for review, 2013-09-03 23:17:41]

https://codereview.chromium.org/23604036/diff/1/Source/core/css/CSSParser-in.cpp
File Source/core/css/CSSParser-in.cpp (right):

https://codereview.chromium.org/23604036/diff/1/Source/core/css/CSSParser-in....
Source/core/css/CSSParser-in.cpp:1156: return
toCSSValueList(dummyStyle->getPropertyCSSValue(CSSPropertyFontFamily).leakRef());
On 2013/09/03 22:40:23, eseidel wrote:
> leakRef?  You mean release and static_ptr_cast?

I don't want to use static_ptr_cast as it is unsafe (ie isn't protected by an
assert).

I missed the fact that leakRef doesn't touch the ref count so I would need an
adoptRef for this to work. I will just use .get() and let the ref count be
touched twice then.

[eseidel, 2013-09-04 22:22:45]

lgtm

[commit-bot: I haz the power, 2013-09-04 22:22:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/23604036/6001

[commit-bot: I haz the power, 2013-09-05 01:24:34]

Change committed as 157255