tools/telemetry/telemetry/core/chrome/cros_browser_finder.py - Issue 23604005: [Telemetry] Implement dirty profile generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/chrome/cros_browser_finder.py

Issue 23604005: [Telemetry] Implement dirty profile generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@generate_profile

Patch Set: Rebase against trunk Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/chrome/android_browser_backend.py ('K') | « tools/telemetry/telemetry/core/chrome/android_browser_finder.py ('k') | tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/chrome/cros_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/chrome/cros_browser_finder.py b/tools/telemetry/telemetry/core/chrome/cros_browser_finder.py

index da795fadb7a7e6c6ffa7f8ca82ba9b0c08129eba..2dccbb2c50318f217e8776561df066931edf7295 100644

--- a/tools/telemetry/telemetry/core/chrome/cros_browser_finder.py

+++ b/tools/telemetry/telemetry/core/chrome/cros_browser_finder.py

@@ -7,7 +7,6 @@ import logging

from telemetry.core import browser

from telemetry.core import possible_browser

-from telemetry.core import profile_types

from telemetry.core.chrome import cros_browser_backend

from telemetry.core.chrome import cros_interface

from telemetry.core.platform import cros_platform_backend

@@ -29,8 +28,9 @@ class PossibleCrOSBrowser(possible_browser.PossibleBrowser):

return 'PossibleCrOSBrowser(browser_type=%s)' % self.browser_type

def Create(self):

- if profile_types.GetProfileCreator(self.options.profile_type):

- raise Exception("Profile creation not currently supported on Chrome OS")

+ if self._options.output_profile_path:

+ raise Exception("Profile generation is not currently supported on Chrome"

+ " OS")

backend = cros_browser_backend.CrOSBrowserBackend(

self.browser_type, self._options, self._cri, self._is_guest)