Issue 23603006: Update build script to use codereview.chromium.org instead of appspot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23603006: Update build script to use codereview.chromium.org instead of appspot (Closed)

Created:
7 years, 3 months ago by jam

Modified:
7 years, 3 months ago

Reviewers:
Nico, brettw

CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/tools/build/

Visibility:
Public.

Update build script to use codereview.chromium.org instead of appspot BUG=273810

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	scripts/tools/run_recipe.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	site_config/config_default.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/23603006/1

7 years, 3 months ago (2013-09-23 22:52:27 UTC) #3

commit-bot: I haz the power

Presubmit check for 23603006-1 failed and returned exit status 1. Running presubmit commit checks ...

7 years, 3 months ago (2013-09-23 22:53:16 UTC) #4

Nico

7 years, 3 months ago (2013-09-24 00:44:34 UTC) #6

blind lgtm stamp based on reading the email thread and the bug.