Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 23601027: Fix list-style-position: inside (Closed)

Created:
7 years, 3 months ago by eae
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Fix list-style-position: inside We currently handle list-style-position: inside incorrectly and in trying to fix this in the past broke handling of it for floating items (r151263). This change reversed that incorrect fix and instead updated RenderListItem to invalidate the preferred width for the containing block once the render tree has been updated to include to marker for list-style-position: inside list markers. BUG=278115 TEST=LayoutTests/fast/lists/list-style-position-inside.html R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157560

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -2 lines) Patch
LayoutTests/fast/css/user-select-none.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
LayoutTests/fast/css/user-select-none-expected.html View 1 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/lists/list-style-position-inside.html View 1 chunk +180 lines, -0 lines 0 comments Download
A LayoutTests/fast/lists/list-style-position-inside-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
Source/core/rendering/InlineTextBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eae
7 years, 3 months ago (2013-09-10 23:36:03 UTC) #1
leviw_travelin_and_unemployed
lgtm
7 years, 3 months ago (2013-09-10 23:43:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/23601027/1
7 years, 3 months ago (2013-09-10 23:43:31 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-11 01:25:21 UTC) #4
Message was sent while issue was closed.
Change committed as 157560

Powered by Google App Engine
This is Rietveld 408576698