Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 23600068: ContentEditable plaintext-only crash fix. (Closed)

Created:
7 years, 3 months ago by rune
Modified:
7 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

ContentEditable plaintext-only crash fix. Calling createLink execCommand on a selection that includes both normal contentEditable and plaintext-only contentEditable caused a crash when applying style in ApplyStyleCommand::applyInlineStyleToNodeRange because the EditingStyle::m_mutableStyle is null. I do not have a well enough understanding of what is going on here to be sure this is the correct fix, but trying to move the check for style()->style further up caused various LayoutTests to fail. BUG=270031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
A LayoutTests/editing/execCommand/crash-on-plaintext-createLink.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/editing/execCommand/crash-on-plaintext-createLink-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
7 years, 3 months ago (2013-09-21 23:02:38 UTC) #1
Z_DONOTUSE
lgtm Seems reasonable.
7 years, 3 months ago (2013-09-23 23:57:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23600068/1
7 years, 3 months ago (2013-09-23 23:58:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=7401
7 years, 3 months ago (2013-09-24 00:13:16 UTC) #4
rune
On 2013/09/24 00:13:16, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 3 months ago (2013-09-24 03:17:03 UTC) #5
leviw_travelin_and_unemployed
Okay. LGTM.
7 years, 3 months ago (2013-09-24 03:43:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23600068/1
7 years, 3 months ago (2013-09-24 03:44:01 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 07:06:08 UTC) #8
Message was sent while issue was closed.
Change committed as 158248

Powered by Google App Engine
This is Rietveld 408576698