Issue 23597051: Use correct pseudo type for page selector specificity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23597051: Use correct pseudo type for page selector specificity. (Closed)

Created:
7 years, 3 months ago by rune

Modified:
7 years, 3 months ago

Reviewers:
dglazkov

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use correct pseudo type for page selector specificity. Page selector specificity did not work because the specificity calculations in CSSSelector::specificityForPage() checked for PseudoClass instead of PagePseudoClass. BUG=294190 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157973

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -1 line)			Patch
A	LayoutTests/printing/page-rule-specificity.html	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/printing/page-rule-specificity-expected.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSSelector.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23597051/1

7 years, 3 months ago (2013-09-18 17:03:53 UTC) #3

Message was sent while issue was closed.

Change committed as 157973

Expand Messages | Collapse Messages