Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 23596011: Set hbrBackground on wndclass, fixes white flash on resize (Closed)

Created:
7 years, 3 months ago by scottmg
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, cpu_(ooo_6.6-7.5)
Visibility:
Public.

Description

Set hbrBackground on wndclass, fixes white flash on resize When in DWM, the DefWindowProc handling of WM_NCPAINT was clearing (to white) in the area that was not yet drawn. When the wndclass's background is set to COLOR_WINDOW this is avoided and the frame appears to stay more "solid". This only affects the white flash in the NC area in the linked bug, not the grey in the content area. We should also consider reverting the compositor.cc change from here http://crrev.com/192657 as it seems to make resize a bit laggier. R=sky@chromium.org BUG=177115 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/base/win/window_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
7 years, 3 months ago (2013-09-05 18:17:10 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-05 20:31:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23596011/1
7 years, 3 months ago (2013-09-05 20:50:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=75970
7 years, 3 months ago (2013-09-06 00:21:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/23596011/1
7 years, 3 months ago (2013-09-06 00:23:54 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 06:35:03 UTC) #6
Message was sent while issue was closed.
Change committed as 221608

Powered by Google App Engine
This is Rietveld 408576698