Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 235943018: Move extensions bindings code out of //chrome (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move extensions bindings code out of //chrome This moves several native handlers out of //chrome/renderer/extensions and into //extensions/renderer. Many of the changes are mechanical. Where applicable, ChromeV8Extension has been wiped out. BUG=359836 R=yoz@chromium.org TBR=reed@google.com for skia +DEPS TBR=ericu@chromium.org for fileapi +DEPS TBR=eseidel@chromium.org for WebKit/public/platform +DEPS TBR=sky@chromium.org for chrome/test TBR=maruel@chromium.org for PRESUBMIT.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264413

Patch Set 1 #

Patch Set 2 : move the rest #

Total comments: 1

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -2025 lines) Patch
M PRESUBMIT.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 6 chunks +0 lines, -35 lines 0 comments Download
D chrome/renderer/extensions/api_definitions_natives.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/renderer/extensions/api_definitions_natives.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/renderer/extensions/binding_generating_native_handler.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/renderer/extensions/binding_generating_native_handler.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/renderer/extensions/blob_native_handler.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/renderer/extensions/blob_native_handler.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/renderer/extensions/content_watcher.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/renderer/extensions/content_watcher.cc View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/renderer/extensions/context_menus_custom_bindings.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/renderer/extensions/context_menus_custom_bindings.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/renderer/extensions/css_native_handler.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/renderer/extensions/css_native_handler.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 2 9 chunks +49 lines, -47 lines 0 comments Download
D chrome/renderer/extensions/document_custom_bindings.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/renderer/extensions/document_custom_bindings.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/renderer/extensions/extension_groups.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/renderer/extensions/file_system_natives.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/renderer/extensions/file_system_natives.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D chrome/renderer/extensions/i18n_custom_bindings.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/renderer/extensions/i18n_custom_bindings.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/renderer/extensions/id_generator_custom_bindings.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/renderer/extensions/id_generator_custom_bindings.cc View 1 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/renderer/extensions/logging_native_handler.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/renderer/extensions/logging_native_handler.cc View 1 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/renderer/extensions/render_view_observer_natives.h View 1 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/renderer/extensions/render_view_observer_natives.cc View 1 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/renderer/extensions/send_request_natives.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/renderer/extensions/send_request_natives.cc View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/renderer/extensions/set_icon_natives.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/renderer/extensions/set_icon_natives.cc View 1 chunk +0 lines, -164 lines 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D chrome/renderer/extensions/utils_native_handler.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/renderer/extensions/utils_native_handler.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M chrome/renderer/translate/translate_helper.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/module_system_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +45 lines, -0 lines 0 comments Download
M extensions/renderer/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A + extensions/renderer/api_definitions_natives.h View 1 chunk +12 lines, -10 lines 0 comments Download
A + extensions/renderer/api_definitions_natives.cc View 2 chunks +12 lines, -11 lines 0 comments Download
A + extensions/renderer/binding_generating_native_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/binding_generating_native_handler.cc View 3 chunks +14 lines, -14 lines 0 comments Download
A + extensions/renderer/blob_native_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/blob_native_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/renderer/content_watcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/content_watcher.cc View 2 chunks +7 lines, -6 lines 0 comments Download
A extensions/renderer/context_menus_custom_bindings.h View 1 chunk +21 lines, -0 lines 0 comments Download
A + extensions/renderer/context_menus_custom_bindings.cc View 2 chunks +3 lines, -5 lines 0 comments Download
A + extensions/renderer/css_native_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/renderer/css_native_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/document_custom_bindings.h View 2 chunks +7 lines, -6 lines 0 comments Download
A + extensions/renderer/document_custom_bindings.cc View 2 chunks +8 lines, -10 lines 0 comments Download
A + extensions/renderer/extension_groups.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/file_system_natives.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/renderer/file_system_natives.cc View 5 chunks +25 lines, -33 lines 0 comments Download
A + extensions/renderer/i18n_custom_bindings.h View 2 chunks +7 lines, -6 lines 0 comments Download
A + extensions/renderer/i18n_custom_bindings.cc View 3 chunks +12 lines, -13 lines 0 comments Download
A + extensions/renderer/id_generator_custom_bindings.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
A + extensions/renderer/id_generator_custom_bindings.cc View 1 1 chunk +6 lines, -8 lines 0 comments Download
A + extensions/renderer/logging_native_handler.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/renderer/logging_native_handler.cc View 1 4 chunks +14 lines, -10 lines 0 comments Download
A + extensions/renderer/render_view_observer_natives.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
A + extensions/renderer/render_view_observer_natives.cc View 1 4 chunks +7 lines, -10 lines 0 comments Download
A + extensions/renderer/send_request_natives.h View 2 chunks +7 lines, -11 lines 0 comments Download
A + extensions/renderer/send_request_natives.cc View 2 chunks +18 lines, -15 lines 0 comments Download
A + extensions/renderer/set_icon_natives.h View 2 chunks +8 lines, -10 lines 0 comments Download
A + extensions/renderer/set_icon_natives.cc View 7 chunks +29 lines, -30 lines 0 comments Download
A + extensions/renderer/utils_native_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + extensions/renderer/utils_native_handler.cc View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ken Rockot(use gerrit already)
Yawz, might you PTAL?
6 years, 8 months ago (2014-04-16 02:21:35 UTC) #1
Ken Rockot(use gerrit already)
Well I lied. It turns out there were only ~5 additional files worth moving, and ...
6 years, 8 months ago (2014-04-16 18:55:52 UTC) #2
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/235943018/diff/20001/chrome/renderer/extensions/dispatcher.cc File chrome/renderer/extensions/dispatcher.cc (right): https://chromiumcodereview.appspot.com/235943018/diff/20001/chrome/renderer/extensions/dispatcher.cc#newcode345 chrome/renderer/extensions/dispatcher.cc:345: explicit ProcessInfoNativeHandler(ScriptContext* context, nit: Usually we only need ...
6 years, 8 months ago (2014-04-16 22:42:21 UTC) #3
Yoyo Zhou
P.S. Seems like we're soon to be able to delete ChromeV8Extension.
6 years, 8 months ago (2014-04-16 22:42:49 UTC) #4
Ken Rockot(use gerrit already)
On 2014/04/16 22:42:49, Yoyo Zhou wrote: > P.S. Seems like we're soon to be able ...
6 years, 8 months ago (2014-04-16 22:45:27 UTC) #5
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-16 22:45:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/235943018/20001
6 years, 8 months ago (2014-04-16 22:47:06 UTC) #7
Ken Rockot(use gerrit already)
The CQ bit was unchecked by rockot@chromium.org
6 years, 8 months ago (2014-04-16 22:47:45 UTC) #8
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-16 23:37:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/235943018/40001
6 years, 8 months ago (2014-04-16 23:38:22 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 04:37:38 UTC) #11
Message was sent while issue was closed.
Change committed as 264413

Powered by Google App Engine
This is Rietveld 408576698