Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 23592023: WebCrypto: Add interface for exportKey(). (Closed)

Created:
7 years, 3 months ago by eroman
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Visibility:
Public.

Description

WebCrypto: Add interface for exportKey(). The spec defines it on SubtleCrypto (http://www.w3.org/TR/WebCryptoAPI/#subtlecrypto-interface) but doesn't give any other details. (The behavior with regard to extractability is inferred by this change) BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157014

Patch Set 1 : #

Patch Set 2 : Rebase, add test expectations, remove platformCrypto nullity check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -2 lines) Patch
A LayoutTests/crypto/exportKey.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/crypto/exportKey-expected.txt View 1 1 chunk +18 lines, -0 lines 0 comments Download
M LayoutTests/crypto/resources/common.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 1 1 chunk +21 lines, -0 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/testing/runner/MockWebCrypto.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/testing/runner/MockWebCrypto.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M public/platform/WebCrypto.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eroman
7 years, 3 months ago (2013-08-30 00:18:20 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-08-30 07:04:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/23592023/3001
7 years, 3 months ago (2013-08-30 07:04:25 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3580
7 years, 3 months ago (2013-08-30 08:56:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/23592023/17001
7 years, 3 months ago (2013-08-30 18:05:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/23592023/28001
7 years, 3 months ago (2013-08-30 18:18:55 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 20:17:25 UTC) #7
Message was sent while issue was closed.
Change committed as 157014

Powered by Google App Engine
This is Rietveld 408576698