Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 23591067: Add last_modified to CopyResource and MoveResource. (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add last_modified to CopyResource and MoveResource. This CL adds last_modified to the CopyResource and MoveResource to the DriveServiceInterface to implement preserving last modified date on Copy and Move. The feature is only supported on Drive API v2, as GData WAPI doesn't have such a function. BUG=282107 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2 lines) Patch
M chrome/browser/chromeos/drive/job_scheduler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/drive/drive_api_service.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 4 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/drive/drive_service_interface.h View 4 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/drive/dummy_drive_service.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 5 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/drive/fake_drive_service_unittest.cc View 12 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/drive/gdata_wapi_service.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 3 months ago (2013-09-24 04:47:54 UTC) #1
kinaba
lgtm
7 years, 3 months ago (2013-09-24 05:20:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23591067/1
7 years, 3 months ago (2013-09-24 06:17:53 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=79880
7 years, 3 months ago (2013-09-24 09:20:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23591067/1
7 years, 3 months ago (2013-09-24 09:21:31 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 11:03:03 UTC) #6
Message was sent while issue was closed.
Change committed as 224974

Powered by Google App Engine
This is Rietveld 408576698