Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 23591052: [Mac] Fix "empty" item position when BMB folder becomes empty. (Closed)

Created:
7 years, 3 months ago by Alexei Svitkine (slow)
Modified:
7 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

[Mac] Fix "empty" item position when BMB folder becomes empty. Fixed at altitude 12000 meters. BUG=227391 TEST=See bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
7 years, 3 months ago (2013-09-16 21:11:05 UTC) #1
Robert Sesek
LGTM
7 years, 3 months ago (2013-09-16 21:12:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23591052/1
7 years, 3 months ago (2013-09-16 21:14:02 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 21:27:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/23591052/1
7 years, 3 months ago (2013-09-16 21:34:59 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 01:23:14 UTC) #6
Message was sent while issue was closed.
Change committed as 223498

Powered by Google App Engine
This is Rietveld 408576698