chrome/browser/safe_browsing/database_manager.h - Issue 23591050: Delete the omahaproxy-backed extension blacklist and clear its entries from the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/database_manager.h

Issue 23591050: Delete the omahaproxy-backed extension blacklist and clear its entries from the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix memory leak in blacklist test Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | chrome/browser/safe_browsing/database_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/database_manager.h

diff --git a/chrome/browser/safe_browsing/database_manager.h b/chrome/browser/safe_browsing/database_manager.h

index 25b7f5a1fdb50d74f6df1b6bd866e1df72c83a48..ed17f5af1a60ffba0daf6c158618f644364fdbd2 100644

--- a/chrome/browser/safe_browsing/database_manager.h

+++ b/chrome/browser/safe_browsing/database_manager.h

@@ -210,6 +210,9 @@ class SafeBrowsingDatabaseManager

protected:

virtual ~SafeBrowsingDatabaseManager();

+ // protected for tests.

+ void NotifyDatabaseUpdateFinished(bool update_succeeded);

private:

friend class base::RefCountedThreadSafe<SafeBrowsingDatabaseManager>;

friend class SafeBrowsingServerTest;

@@ -295,8 +298,6 @@ class SafeBrowsingDatabaseManager

void DatabaseUpdateFinished(bool update_succeeded);

- void NotifyDatabaseUpdateFinished(bool update_succeeded);

// Called on the db thread to close the database. See CloseDatabase().

void OnCloseDatabase();