Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2088)

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 23591050: Delete the omahaproxy-backed extension blacklist and clear its entries from the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix memory leak in blacklist test Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer_browsertest.cc
diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc
index 8ebbfbec59f7b9d73fb9d458512dc9f71d4649ac..105b4c686980899a738d5558821c4a46bb637ab2 100644
--- a/chrome/browser/extensions/crx_installer_browsertest.cc
+++ b/chrome/browser/extensions/crx_installer_browsertest.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_system.h"
+#include "chrome/browser/extensions/fake_safe_browsing_database_manager.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
@@ -447,13 +448,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest,
}
IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, Blacklist) {
- extensions::Blacklist* blacklist =
- ExtensionSystem::Get(profile())->blacklist();
+ scoped_refptr<FakeSafeBrowsingDatabaseManager> blacklist_db(
+ new FakeSafeBrowsingDatabaseManager(true));
+ Blacklist::ScopedDatabaseManagerForTest scoped_blacklist_db(blacklist_db);
- // Fake the blacklisting of the extension we're about to install by
- // pretending that we get a blacklist update which includes it.
- const std::string kId = "gllekhaobjnhgeagipipnkpmmmpchacm";
- blacklist->SetFromUpdater(std::vector<std::string>(1, kId), "some-version");
+ blacklist_db->SetUnsafe("gllekhaobjnhgeagipipnkpmmmpchacm");
base::FilePath crx_path = test_data_dir_.AppendASCII("theme_hidpi_crx")
.AppendASCII("theme_hidpi.crx");
« no previous file with comments | « chrome/browser/extensions/blacklist_unittest.cc ('k') | chrome/browser/extensions/extension_blacklist_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698