Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7908)

Unified Diff: chrome/browser/extensions/api/management/management_browsertest.cc

Issue 23591050: Delete the omahaproxy-backed extension blacklist and clear its entries from the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix memory leak in blacklist test Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/extensions/external_cache.cc ('k') | chrome/browser/extensions/blacklist.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/management/management_browsertest.cc
diff --git a/chrome/browser/extensions/api/management/management_browsertest.cc b/chrome/browser/extensions/api/management/management_browsertest.cc
index 999ae85f17834a878d85b9bf4348198861435280..ad12efc1335bc2c8df7db7c169845101b8f8ba5c 100644
--- a/chrome/browser/extensions/api/management/management_browsertest.cc
+++ b/chrome/browser/extensions/api/management/management_browsertest.cc
@@ -273,9 +273,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, MAYBE_AutoUpdate) {
ASSERT_EQ("ogjcoiohnmldgjemafoockdghcjciccf", extension->id());
ASSERT_EQ("1.0", extension->VersionString());
- // We don't want autoupdate blacklist checks.
extensions::ExtensionUpdater::CheckParams params;
- params.check_blacklist = false;
params.callback =
base::Bind(&NotificationListener::OnFinished,
base::Unretained(&notification_listener));
@@ -361,9 +359,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,
ASSERT_EQ("ogjcoiohnmldgjemafoockdghcjciccf", extension->id());
ASSERT_EQ("1.0", extension->VersionString());
- // We don't want autoupdate blacklist checks.
extensions::ExtensionUpdater::CheckParams params;
- params.check_blacklist = false;
params.callback =
base::Bind(&NotificationListener::OnFinished,
base::Unretained(&notification_listener));
@@ -405,9 +401,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, MAYBE_ExternalUrlUpdate) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";
- // We don't want autoupdate blacklist checks.
extensions::ExtensionUpdater::CheckParams params;
- params.check_blacklist = false;
base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
@@ -491,9 +485,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalPolicyRefresh) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";
- // We don't want autoupdate blacklist checks.
- extensions::ExtensionUpdater::CheckParams params;
- params.check_blacklist = false;
base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
@@ -566,7 +557,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,
browser()->profile())->extension_service();
const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";
extensions::ExtensionUpdater::CheckParams params;
- params.check_blacklist = false;
service->updater()->set_default_check_params(params);
const size_t size_before = service->extensions()->size();
base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");
« no previous file with comments | « chrome/browser/chromeos/extensions/external_cache.cc ('k') | chrome/browser/extensions/blacklist.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698