chrome/browser/chromeos/extensions/external_cache.cc - Issue 23591050: Delete the omahaproxy-backed extension blacklist and clear its entries from the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/external_cache.cc

Issue 23591050: Delete the omahaproxy-backed extension blacklist and clear its entries from the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix memory leak in blacklist test Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/external_cache.h ('k') | chrome/browser/extensions/api/management/management_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/external_cache.cc

diff --git a/chrome/browser/chromeos/extensions/external_cache.cc b/chrome/browser/chromeos/extensions/external_cache.cc

index edda312238666c44e502131a92128392e45d74f6..eb47ec2ce01388093df56a528c5a801c8f4ec50c 100644

--- a/chrome/browser/chromeos/extensions/external_cache.cc

+++ b/chrome/browser/chromeos/extensions/external_cache.cc

@@ -163,15 +163,6 @@ void ExternalCache::OnExtensionDownloadFinished(

std::string(version)));

}

-void ExternalCache::OnBlacklistDownloadFinished(

- const std::string& data,

- const std::string& package_hash,

- const std::string& version,

- const extensions::ExtensionDownloaderDelegate::PingResult& ping_result,

- const std::set<int>& request_ids) {

- NOTREACHED();

bool ExternalCache::IsExtensionPending(const std::string& id) {

// Pending means that there is no installed version yet.

return extensions_->HasKey(id) && !cached_extensions_->HasKey(id);