Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: chrome/common/extensions/permissions/permission_message.cc

Issue 23591040: Use ICU for string pluralization in the extension permission dialog. (Closed) Base URL: http://git.chromium.org/chromium/src.git@gtk-extension-install-dialog
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/permissions/permission_message.h" 5 #include "chrome/common/extensions/permissions/permission_message.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "grit/generated_resources.h" 9 #include "grit/generated_resources.h"
10 #include "ui/base/l10n/l10n_util.h" 10 #include "ui/base/l10n/l10n_util.h"
(...skipping 27 matching lines...) Expand all
38 case 3: 38 case 3:
39 message_id = kHosts3; 39 message_id = kHosts3;
40 message = l10n_util::GetStringFUTF16(IDS_EXTENSION_PROMPT_WARNING_3_HOSTS, 40 message = l10n_util::GetStringFUTF16(IDS_EXTENSION_PROMPT_WARNING_3_HOSTS,
41 UTF8ToUTF16(host_list[0]), 41 UTF8ToUTF16(host_list[0]),
42 UTF8ToUTF16(host_list[1]), 42 UTF8ToUTF16(host_list[1]),
43 UTF8ToUTF16(host_list[2])); 43 UTF8ToUTF16(host_list[2]));
44 break; 44 break;
45 default: 45 default:
46 message_id = kHosts4OrMore; 46 message_id = kHosts4OrMore;
47 47
48 message = l10n_util::GetStringFUTF16( 48 const int kRetainedFilesMessageIDs[6] = {
49 IDS_EXTENSION_PROMPT_WARNING_HOSTS, 49 IDS_EXTENSION_PROMPT_WARNING_HOSTS_DEFAULT,
50 base::IntToString16(host_list.size())); 50 IDS_EXTENSION_PROMPT_WARNING_HOST_SINGULAR,
51 IDS_EXTENSION_PROMPT_WARNING_HOSTS_ZERO,
52 IDS_EXTENSION_PROMPT_WARNING_HOSTS_TWO,
53 IDS_EXTENSION_PROMPT_WARNING_HOSTS_FEW,
54 IDS_EXTENSION_PROMPT_WARNING_HOSTS_MANY,
55 };
56 std::vector<int> message_ids;
57 for (size_t i = 0; i < arraysize(kRetainedFilesMessageIDs); i++) {
58 message_ids.push_back(kRetainedFilesMessageIDs[i]);
59 }
60 message = l10n_util::GetPluralStringFUTF16(message_ids, host_list.size());
51 61
52 for (size_t i = 0; i < host_list.size(); ++i) { 62 for (size_t i = 0; i < host_list.size(); ++i) {
53 if (i > 0) 63 if (i > 0)
54 details += ASCIIToUTF16("\n"); 64 details += ASCIIToUTF16("\n");
55 details += l10n_util::GetStringFUTF16( 65 details += l10n_util::GetStringFUTF16(
56 IDS_EXTENSION_PROMPT_WARNING_HOST_LIST_ENTRY, 66 IDS_EXTENSION_PROMPT_WARNING_HOST_LIST_ENTRY,
57 UTF8ToUTF16(host_list[i])); 67 UTF8ToUTF16(host_list[i]));
58 } 68 }
59 } 69 }
60 70
61 return PermissionMessage(message_id, message, details); 71 return PermissionMessage(message_id, message, details);
62 } 72 }
63 73
64 PermissionMessage::PermissionMessage( 74 PermissionMessage::PermissionMessage(
65 PermissionMessage::ID id, const string16& message) 75 PermissionMessage::ID id, const string16& message)
66 : id_(id), 76 : id_(id),
67 message_(message) { 77 message_(message) {
68 } 78 }
69 79
70 PermissionMessage::PermissionMessage( 80 PermissionMessage::PermissionMessage(
71 PermissionMessage::ID id, const string16& message, const string16& details) 81 PermissionMessage::ID id, const string16& message, const string16& details)
72 : id_(id), 82 : id_(id),
73 message_(message), 83 message_(message),
74 details_(details) { 84 details_(details) {
75 } 85 }
76 86
77 PermissionMessage::~PermissionMessage() {} 87 PermissionMessage::~PermissionMessage() {}
78 88
79 } // namespace extensions 89 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698