Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 23591035: Add a script which prints recent changes in a set of repos. (Closed)

Created:
7 years, 3 months ago by Siva Chandra
Modified:
6 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Visibility:
Public.

Description

Add a script which prints recent changes in a set of repos. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
A build/tree_truth.sh View 1 chunk +101 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Siva Chandra
This is just moving this file from an internal repo to a public one.
7 years, 3 months ago (2013-09-13 00:39:52 UTC) #1
iannucci
this mostly lgtm, I don't like the BUILD_STEP annotations (they're deprecated), so we'll want clean ...
7 years, 3 months ago (2013-09-13 18:52:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/23591035/1
7 years, 3 months ago (2013-09-13 19:10:12 UTC) #3
commit-bot: I haz the power
Change committed as 223097
7 years, 3 months ago (2013-09-13 19:11:36 UTC) #4
Nico
Can internal build/tree_truth.sh go away now? (nit: Scripts longer than 30 lines shouldn't be written ...
6 years, 8 months ago (2014-04-03 23:18:05 UTC) #5
iannucci
On 2014/04/03 23:18:05, Nico wrote: > Can internal build/tree_truth.sh go away now? > Removal of ...
6 years, 8 months ago (2014-04-03 23:23:36 UTC) #6
iannucci
6 years, 8 months ago (2014-04-03 23:24:03 UTC) #7
Message was sent while issue was closed.
On 2014/04/03 23:23:36, iannucci wrote:
> On 2014/04/03 23:18:05, Nico wrote:
> > Can internal build/tree_truth.sh go away now?
> > 
> 
> Removal of code? Yes please.
> 
> > (nit: Scripts longer than 30 lines shouldn't be written in bash as that's
> > unreadable. It also can't run on windows.)
> 
> Also agree.

(they should be written in perl)



:P

Powered by Google App Engine
This is Rietveld 408576698