Revalidation header blacklisting should be case-insensitive.

Revalidation header blacklisting should be case-insensitive.

Headers like 'content-type' should be ignored for 304 responses, even if
they are delivered as 'Content-Type', or 'CoNtEnT-TyPe', etc.

BUG=246875
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157358

[Mike West, 2013-09-05 13:51:23]

Hi Nate, would you mind taking a look at this CL?

-mike

[Mike West, 2013-09-05 13:51:24]

Hi Nate, would you mind taking a look at this CL?

-mike

[Nate Chapin, 2013-09-05 16:10:28]

lgtm

[commit-bot: I haz the power, 2013-09-05 16:27:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/23591029/11001

[commit-bot: I haz the power, 2013-09-05 16:27:43]

Failed to apply patch for
LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  A        
LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php
  Copied LayoutTests/http/tests/cache/resources/stylesheet304.php ->
LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php
  patching file
LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php
  Hunk #1 FAILED at 1.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php.rej

Patch:   NR 
LayoutTests/http/tests/cache/resources/stylesheet304.php->LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php
Index: LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php
diff --git a/LayoutTests/http/tests/cache/resources/stylesheet304.php
b/LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php
similarity index 86%
copy from LayoutTests/http/tests/cache/resources/stylesheet304.php
copy to
LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php
index
1588a5b95fbd51da68ef6155ae6e8236bc96908b..2adf6c8279e664ea1cb6f0d031c0dfde26219cee
100644
--- a/LayoutTests/http/tests/cache/resources/stylesheet304.php
+++ b/LayoutTests/http/tests/cache/resources/stylesheet304-bad-content-type.php
@@ -1,21 +1,21 @@
-<?php
-require_once '../../resources/portabilityLayer.php';
-
-clearstatcache();
-
-if ($_SERVER["HTTP_IF_MODIFIED_SINCE"]) {
-    header("HTTP/1.0 304 Not Modified");
-    exit();
-}
-$one_year = 12 * 31 * 24 * 60 * 60;
-$last_modified = gmdate(DATE_RFC1123, time() - $one_year);
-$expires = gmdate(DATE_RFC1123, time() + $one_year);
-
-header('Cache-Control: public, max-age=' . $one_year);
-header('Expires: ' . $expires);
-header('Content-Type: text/css');
-header('Content-Length: 0');
-header('Etag: 123456789');
-header('Last-Modified: ' . $last_modified);
-exit();
-?>
+<?php
+require_once '../../resources/portabilityLayer.php';
+
+clearstatcache();
+
+if ($_SERVER["HTTP_IF_MODIFIED_SINCE"]) {
+    header("HTTP/1.0 304 Not Modified");
+    header("Content-Type: text/plain");
+    exit();
+}
+$one_year = 12 * 31 * 24 * 60 * 60;
+$last_modified = gmdate(DATE_RFC1123, time() - $one_year);
+$expires = gmdate(DATE_RFC1123, time() + $one_year);
+
+header('Cache-Control: public, max-age=' . $one_year);
+header('Expires: ' . $expires);
+header('Content-Type: text/css');
+header('Etag: 123456789');
+header('Last-Modified: ' . $last_modified);
+?>
+#test { background-color: rgb(0, 255, 0); }

[Mike West, 2013-09-05 16:30:36]

Um. That's a new file? How is it conflicting? :)

[Mike West, 2013-09-05 16:37:26]

On 2013/09/05 16:30:36, Mike West wrote:
> Um. That's a new file? How is it conflicting? :)

Filed http://crbug.com/285792; I'll upload a new patch tomorrow.

[Isaac (away), 2013-09-05 20:07:08]

The file got detected a copy / modification of a copy.  You can tell on rietveld
by the 'A+' or by examining raw patch.

You can fix by uploading with git cl upload and specifying one of:
  --similarity=SIM      Sets the percentage that a pair of files need to match
                        in order to be considered copies (default 50)
  --find-copies         Allows git to look for copies.
  --no-find-copies      Disallows git from looking for copies.

[commit-bot: I haz the power, 2013-09-06 07:10:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/23591029/22001

[Mike West, 2013-09-06 07:10:13]

On 2013/09/05 20:07:08, Isaac wrote:
> The file got detected a copy / modification of a copy.  You can tell on
rietveld
> by the 'A+' or by examining raw patch.
> 
> You can fix by uploading with git cl upload and specifying one of:
>   --similarity=SIM      Sets the percentage that a pair of files need to match
>                         in order to be considered copies (default 50)
>   --find-copies         Allows git to look for copies.
>   --no-find-copies      Disallows git from looking for copies.

Thanks Isaac!

[commit-bot: I haz the power, 2013-09-06 08:42:39]

Change committed as 157358