Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 23591028: [Cleanup] fix macro, comments and unused includes (Closed)

Created:
7 years, 3 months ago by oshima
Modified:
7 years, 3 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

fix macro, comments and unused includes BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221499

Patch Set 1 : #

Total comments: 4

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M ash/root_window_settings.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ash/root_window_settings.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
7 years, 3 months ago (2013-09-05 16:33:07 UTC) #1
Daniel Erat
https://codereview.chromium.org/23591028/diff/2001/ash/root_window_settings.h File ash/root_window_settings.h (right): https://codereview.chromium.org/23591028/diff/2001/ash/root_window_settings.h#newcode38 ash/root_window_settings.h:38: // Creates and returns RootWindowSettings for |root|. nit: either ...
7 years, 3 months ago (2013-09-05 16:56:33 UTC) #2
oshima
https://codereview.chromium.org/23591028/diff/2001/ash/root_window_settings.h File ash/root_window_settings.h (right): https://codereview.chromium.org/23591028/diff/2001/ash/root_window_settings.h#newcode38 ash/root_window_settings.h:38: // Creates and returns RootWindowSettings for |root|. On 2013/09/05 ...
7 years, 3 months ago (2013-09-05 17:05:54 UTC) #3
Daniel Erat
lgtm
7 years, 3 months ago (2013-09-05 17:22:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/23591028/10001
7 years, 3 months ago (2013-09-05 17:29:05 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 20:14:04 UTC) #6
Message was sent while issue was closed.
Change committed as 221499

Powered by Google App Engine
This is Rietveld 408576698