Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 23589007: Add infrastructure for testing the debugger code. (Closed)

Created:
7 years, 3 months ago by dsinclair
Modified:
7 years, 3 months ago
Reviewers:
mtklein, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add infrastructure for testing the debugger code. This creates the necessarily files and GYP targets to start adding tests for the debugger code. There is currently one test added, more will be added once the infrastructure is in place. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11342

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
M gyp/debugger.gyp View 2 chunks +19 lines, -6 lines 0 comments Download
M gyp/tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A tests/DebugCanvasTest.cpp View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dsinclair
mtklein, PTAL. This is extracting the testing code from the other toString CL.
7 years, 3 months ago (2013-09-11 15:06:38 UTC) #1
mtklein
On 2013/09/11 15:06:38, dsinclair wrote: > mtklein, PTAL. This is extracting the testing code from ...
7 years, 3 months ago (2013-09-11 15:15:10 UTC) #2
mtklein
Ooops, meant to actually send the suggestion. https://codereview.chromium.org/23589007/diff/1/tests/DebugCanvasTest.cpp File tests/DebugCanvasTest.cpp (right): https://codereview.chromium.org/23589007/diff/1/tests/DebugCanvasTest.cpp#newcode18 tests/DebugCanvasTest.cpp:18: const SkTDArray<SkString*>* ...
7 years, 3 months ago (2013-09-11 15:15:28 UTC) #3
dsinclair
https://codereview.chromium.org/23589007/diff/1/tests/DebugCanvasTest.cpp File tests/DebugCanvasTest.cpp (right): https://codereview.chromium.org/23589007/diff/1/tests/DebugCanvasTest.cpp#newcode18 tests/DebugCanvasTest.cpp:18: const SkTDArray<SkString*>* result = cmds[0]->Info(); On 2013/09/11 15:15:28, mtklein ...
7 years, 3 months ago (2013-09-11 15:20:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dsinclair@chromium.org/23589007/6001
7 years, 3 months ago (2013-09-11 15:21:04 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
7 years, 3 months ago (2013-09-11 15:28:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dsinclair@chromium.org/23589007/6001
7 years, 3 months ago (2013-09-11 21:00:21 UTC) #7
commit-bot: I haz the power
Change committed as 11342
7 years, 3 months ago (2013-09-18 13:01:21 UTC) #8
robertphillips
7 years, 3 months ago (2013-09-18 13:29:52 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698