Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 23587029: gm: add a flag to force perspective usage in all gms (Closed)

Created:
7 years, 3 months ago by edisonn
Modified:
7 years, 2 months ago
Reviewers:
epoger, borenet, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

gm: add a flag to force perspective usage in all gms BUG= Committed: http://code.google.com/p/skia/source/detail?r=11487

Patch Set 1 #

Patch Set 2 : gm test #

Total comments: 2

Patch Set 3 : update the cl to force perspective usage in gms #

Patch Set 4 : add reset of matrix in GM constructor too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M gm/gm.h View 1 2 3 chunks +9 lines, -1 line 0 comments Download
M gm/gm.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gm/gmmain.cpp View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
edisonn
7 years, 3 months ago (2013-09-23 18:40:13 UTC) #1
reed1
https://codereview.chromium.org/23587029/diff/4001/gm/gm.h File gm/gm.h (right): https://codereview.chromium.org/23587029/diff/4001/gm/gm.h#newcode79 gm/gm.h:79: SkMatrix getInitialTransform() const { I think we could generalize ...
7 years, 3 months ago (2013-09-23 18:48:40 UTC) #2
edisonn
https://codereview.chromium.org/23587029/diff/4001/gm/gm.h File gm/gm.h (right): https://codereview.chromium.org/23587029/diff/4001/gm/gm.h#newcode79 gm/gm.h:79: SkMatrix getInitialTransform() const { On 2013/09/23 18:48:40, reed1 wrote: ...
7 years, 3 months ago (2013-09-23 19:38:03 UTC) #3
reed1
where is GM constructor? It will need to call fStarterMatrix.reset();
7 years, 3 months ago (2013-09-23 20:34:48 UTC) #4
edisonn
On 2013/09/23 20:34:48, reed1 wrote: > where is GM constructor? It will need to call ...
7 years, 3 months ago (2013-09-24 20:53:44 UTC) #5
edisonn
On 2013/09/24 20:53:44, edisonn wrote: > On 2013/09/23 20:34:48, reed1 wrote: > > where is ...
7 years, 2 months ago (2013-09-26 19:58:08 UTC) #6
reed1
lgtm
7 years, 2 months ago (2013-09-26 20:33:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/edisonn@google.com/23587029/17001
7 years, 2 months ago (2013-09-26 20:35:02 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 20:44:28 UTC) #9
Message was sent while issue was closed.
Change committed as 11487

Powered by Google App Engine
This is Rietveld 408576698