Issue 23587014: Add bit to GrGLCaps for fixed function support

Issue 23587014: Add bit to GrGLCaps for fixed function support (Closed)

Created:
7 years, 3 months ago by bsalomon

Modified:
7 years, 3 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add bit to GrGLCaps for fixed function support Committed: http://code.google.com/p/skia/source/detail?r=11043

Patch Set 2 : Add printout for new bool and other fields #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
M	src/gpu/gl/GrGLCaps.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	1	5 chunks	+9 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 question https://codereview.chromium.org/23587014/diff/1/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/23587014/diff/1/src/gpu/gl/GrGLCaps.cpp#newcode610 src/gpu/gl/GrGLCaps.cpp:610: GrPrintf("Core Profile: %s\n", (fIsCoreProfile ? ...

7 years, 3 months ago (2013-08-30 15:22:18 UTC) #2

bsalomon

https://codereview.chromium.org/23587014/diff/1/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/23587014/diff/1/src/gpu/gl/GrGLCaps.cpp#newcode610 src/gpu/gl/GrGLCaps.cpp:610: GrPrintf("Core Profile: %s\n", (fIsCoreProfile ? "YES" : "NO")); On ...

7 years, 3 months ago (2013-08-30 17:41:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/23587014/6001

7 years, 3 months ago (2013-08-30 17:41:55 UTC) #4

Message was sent while issue was closed.

Change committed as 11043

Expand Messages | Collapse Messages