Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 23587011: Fix building with Java 7 (Closed)

Created:
7 years, 3 months ago by Simon Brenner
Modified:
7 years, 3 months ago
Reviewers:
bulach, joth
CC:
chromium-reviews, erikwright+watch_chromium.org, Daniel Bratell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix building with Java 7 javap includes type parameters in Java 7, causing jni_generator.py to generate invalid C++ code. Fix by stripping away anything after a '<'. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221027

Patch Set 1 #

Patch Set 2 : Add test case #

Total comments: 1

Patch Set 3 : Linewrap test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M base/android/jni_generator/jni_generator.py View 1 chunk +3 lines, -0 lines 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 1 2 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Simon Brenner
7 years, 3 months ago (2013-08-29 15:32:50 UTC) #1
joth
Thanks for the fix! Can you add a variation to testFromJavaP in jni_generator_tests.py to cover ...
7 years, 3 months ago (2013-08-29 18:17:20 UTC) #2
Simon Brenner
On 2013/08/29 18:17:20, joth wrote: > Thanks for the fix! Can you add a variation ...
7 years, 3 months ago (2013-08-30 08:32:04 UTC) #3
joth
Thanks! It lg2m but please wait for @bulach to confirm too. https://codereview.chromium.org/23587011/diff/5001/base/android/jni_generator/jni_generator_tests.py File base/android/jni_generator/jni_generator_tests.py (right): ...
7 years, 3 months ago (2013-08-31 02:43:38 UTC) #4
bulach
lgtm % joth's comment (I think presubmit / CQ will fail with >80 cols for ...
7 years, 3 months ago (2013-09-02 18:21:18 UTC) #5
Simon Brenner
On 2013/09/02 18:21:18, bulach wrote: > lgtm % joth's comment (I think presubmit / CQ ...
7 years, 3 months ago (2013-09-03 10:00:56 UTC) #6
bulach
lgtm, thanks! :) I think you can just hit the CQ button, but let me ...
7 years, 3 months ago (2013-09-03 15:31:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@opera.com/23587011/12001
7 years, 3 months ago (2013-09-03 15:43:23 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 21:22:51 UTC) #9
Message was sent while issue was closed.
Change committed as 221027

Powered by Google App Engine
This is Rietveld 408576698