Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 23583055: webkit: Kill support/ directory. (Closed)

Created:
7 years, 3 months ago by tfarina
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, jochen (gone - plz use gerrit), jamesr, Jói, tkent
Visibility:
Public.

Description

webkit: Kill support/ directory. - Rename webkit_support.gyp to webkit_glue.gyp - Move it into glue/ directory. - Remove DEPS and OWNERS file. BUG=265753 R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -53 lines) Patch
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_plugin.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 5 chunks +10 lines, -10 lines 0 comments Download
A + webkit/glue/webkit_glue.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/support/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D webkit/support/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/support/webkit_support.gyp View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
tfarina
Darin, I think you can cover everything since this is mostly mechanical. Jochen -> chrome ...
7 years, 3 months ago (2013-09-20 02:52:27 UTC) #1
tfarina
tkent -> webkit/support fyi
7 years, 3 months ago (2013-09-20 02:57:33 UTC) #2
jamesr
webkit/support is not linked into production targets but webkit/glue is. Are you sure you aren't ...
7 years, 3 months ago (2013-09-20 03:45:57 UTC) #3
tfarina
On 2013/09/20 03:45:57, jamesr wrote: > webkit/support is not linked into production targets but webkit/glue ...
7 years, 3 months ago (2013-09-20 12:49:07 UTC) #4
jamesr
Ah right, there's no code here :). lgtm+++++
7 years, 3 months ago (2013-09-20 20:33:42 UTC) #5
tfarina
More focused owners for approval. Lei -> chrome Joi -> components Thanks!
7 years, 3 months ago (2013-09-23 16:12:48 UTC) #6
Jói
//components LGTM.
7 years, 3 months ago (2013-09-23 16:34:43 UTC) #7
Lei Zhang
chrome/ lgtm
7 years, 3 months ago (2013-09-23 18:31:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23583055/1
7 years, 3 months ago (2013-09-23 19:56:06 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=26943
7 years, 3 months ago (2013-09-23 20:12:21 UTC) #10
tfarina
On 2013/09/23 20:12:21, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 3 months ago (2013-09-23 23:06:38 UTC) #11
darin (slow to review)
LGTM
7 years, 3 months ago (2013-09-23 23:19:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23583055/1
7 years, 3 months ago (2013-09-23 23:30:21 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 02:54:56 UTC) #14
Message was sent while issue was closed.
Change committed as 224864

Powered by Google App Engine
This is Rietveld 408576698