Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 23583043: Fix linking problem on Windows with ENABLE_LEGACY_NOTIFICATIONS disabled (Closed)

Created:
7 years, 3 months ago by Rafał Chłodnicki
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix linking problem on Windows with LEGACY_NOTIFICATIONS support disabled V8NotificationCenter bindings (generated from NotificationCenter.idl) are required to link this code. Those are conditional on LEGACY_NOTIFICATIONS though so same condition must be applied to this code. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157776

Patch Set 1 #

Patch Set 2 : style fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/modules/notifications/NotificationCenter.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M Source/modules/notifications/NotificationCenter.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Rafał Chłodnicki
7 years, 3 months ago (2013-09-12 14:57:44 UTC) #1
Peter Beverloo
lgtm, thanks! I wonder why this error didn't show up on the Android bots, where ...
7 years, 3 months ago (2013-09-12 15:35:32 UTC) #2
Rafał Chłodnicki
On 2013/09/12 15:35:32, Peter Beverloo wrote: > lgtm, thanks! > > I wonder why this ...
7 years, 3 months ago (2013-09-12 15:38:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rchlodnicki@opera.com/23583043/1003
7 years, 3 months ago (2013-09-12 19:24:48 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=6887
7 years, 3 months ago (2013-09-12 19:35:53 UTC) #5
Peter Beverloo
On 2013/09/12 19:35:53, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 3 months ago (2013-09-13 13:12:23 UTC) #6
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-13 17:43:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rchlodnicki@opera.com/23583043/1003
7 years, 3 months ago (2013-09-13 17:43:47 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 19:48:24 UTC) #9
Message was sent while issue was closed.
Change committed as 157776

Powered by Google App Engine
This is Rietveld 408576698