Issue 23583023: Merge TetheringAdbFilter into PortForwardingController::Connection class.

Issue 23583023: Merge TetheringAdbFilter into PortForwardingController::Connection class. (Closed)

Created:
7 years, 3 months ago by Vladislav Kaznacheev

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Merge TetheringAdbFilter into PortForwardingController::Connection class. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220616

Patch Set 3 : Addressed comments #

Patch Set 4 : Rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -147 lines)			Patch
	M	chrome/browser/devtools/port_forwarding_controller.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/devtools/port_forwarding_controller.cc	View	1 2 3	12 chunks	+102 lines, -146 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/23583023/diff/3001/chrome/browser/devtools/port_forwarding_controller.cc File chrome/browser/devtools/port_forwarding_controller.cc (right): https://codereview.chromium.org/23583023/diff/3001/chrome/browser/devtools/port_forwarding_controller.cc#newcode345 chrome/browser/devtools/port_forwarding_controller.cc:345: (*registry_)[device_->serial()] = this; Lets balance this in destructor. https://codereview.chromium.org/23583023/diff/3001/chrome/browser/devtools/port_forwarding_controller.cc#newcode349 ...

7 years, 3 months ago (2013-08-30 09:39:14 UTC) #2

Vladislav Kaznacheev

https://chromiumcodereview.appspot.com/23583023/diff/3001/chrome/browser/devtools/port_forwarding_controller.cc File chrome/browser/devtools/port_forwarding_controller.cc (right): https://chromiumcodereview.appspot.com/23583023/diff/3001/chrome/browser/devtools/port_forwarding_controller.cc#newcode345 chrome/browser/devtools/port_forwarding_controller.cc:345: (*registry_)[device_->serial()] = this; On 2013/08/30 09:39:14, pfeldman wrote: > ...

7 years, 3 months ago (2013-08-30 11:56:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/23583023/12001

7 years, 3 months ago (2013-08-30 12:24:31 UTC) #5

Message was sent while issue was closed.

Change committed as 220616

Expand Messages | Collapse Messages