[SyncFS] Add MetadataDatabase::PopulateInitialData

[SyncFS] Add MetadataDatabase::PopulateInitialData

* Add a method to populate database with initial data.
* Add a test for it.

BUG=240165
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221671

[tzik, 2013-09-05 08:16:47]

PTL

[kinuko, 2013-09-05 08:43:43]

looks good, I have a few (possibly basic) questions

https://codereview.chromium.org/23582013/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/23582013/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:177:
tracker->set_active(false);
Initially we add this as non-active REGULAR tracker?

https://codereview.chromium.org/23582013/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:611: const
google_apis::FileResource& folder_resource =  **itr;
nit: extra space

https://codereview.chromium.org/23582013/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:634:
WriteToDatabase(batch.Pass(), callback);
We don't call PutServiceMetadataToBatch since it's implicitly called in
GetNextTrackerID..?

[tzik, 2013-09-05 09:17:02]

Thanks! Updated!

https://codereview.chromium.org/23582013/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/23582013/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:177:
tracker->set_active(false);
On 2013/09/05 08:43:43, kinuko wrote:
> Initially we add this as non-active REGULAR tracker?

Yes, we do.
The tracker will be registered as a app-root afterward, but at this point it is
not.
I added a brief comment to the header.

https://codereview.chromium.org/23582013/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:611: const
google_apis::FileResource& folder_resource =  **itr;
On 2013/09/05 08:43:43, kinuko wrote:
> nit: extra space

Done.

https://codereview.chromium.org/23582013/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:634:
WriteToDatabase(batch.Pass(), callback);
On 2013/09/05 08:43:43, kinuko wrote:
> We don't call PutServiceMetadataToBatch since it's implicitly called in
> GetNextTrackerID..?

I just forgot to call that. Good catch!
Fixed.

[kinuko, 2013-09-05 10:20:58]

lgtm

[nhiroki, 2013-09-05 10:55:19]

lgtm

[commit-bot: I haz the power, 2013-09-05 12:12:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/23582013/8001

[commit-bot: I haz the power, 2013-09-05 12:45:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-06 06:07:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/23582013/36001

[commit-bot: I haz the power, 2013-09-06 08:02:54]

Retried try job too often on linux_chromeos for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-06 09:52:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/23582013/36001

[commit-bot: I haz the power, 2013-09-06 10:19:45]

Change committed as 221671