Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: chrome/browser/extensions/extension_prefs.cc

Issue 23581015: Reland r223124: Don't clear existing extension-defined preferences and content settings when reload… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_prefs.cc
diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc
index 24f2d84a2650d97d2d3f478826576e478b30d183..3c66561322b308e369e426e79ba805e4f3440c34 100644
--- a/chrome/browser/extensions/extension_prefs.cc
+++ b/chrome/browser/extensions/extension_prefs.cc
@@ -1835,13 +1835,26 @@ void ExtensionPrefs::FinishExtensionInfoPrefs(
const syncer::StringOrdinal& suggested_page_ordinal,
DictionaryValue* extension_dict) {
// Reinitializes various preferences with empty dictionaries.
- extension_dict->Set(pref_names::kPrefPreferences, new DictionaryValue);
- extension_dict->Set(pref_names::kPrefIncognitoPreferences,
- new DictionaryValue);
- extension_dict->Set(pref_names::kPrefRegularOnlyPreferences,
- new DictionaryValue);
- extension_dict->Set(pref_names::kPrefContentSettings, new ListValue);
- extension_dict->Set(pref_names::kPrefIncognitoContentSettings, new ListValue);
+ if (!extension_dict->HasKey(pref_names::kPrefPreferences))
+ extension_dict->Set(pref_names::kPrefPreferences, new DictionaryValue);
+
+ if (!extension_dict->HasKey(pref_names::kPrefIncognitoPreferences)) {
+ extension_dict->Set(pref_names::kPrefIncognitoPreferences,
+ new DictionaryValue);
+ }
+
+ if (!extension_dict->HasKey(pref_names::kPrefRegularOnlyPreferences)) {
+ extension_dict->Set(pref_names::kPrefRegularOnlyPreferences,
+ new DictionaryValue);
+ }
+
+ if (!extension_dict->HasKey(pref_names::kPrefContentSettings))
+ extension_dict->Set(pref_names::kPrefContentSettings, new ListValue);
+
+ if (!extension_dict->HasKey(pref_names::kPrefIncognitoContentSettings)) {
+ extension_dict->Set(pref_names::kPrefIncognitoContentSettings,
+ new ListValue);
+ }
// If this point has been reached, any pending installs should be considered
// out of date.
« no previous file with comments | « chrome/browser/extensions/extension_pref_value_map.cc ('k') | chrome/browser/managed_mode/managed_mode_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698