Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 23581015: Reland r223124: Don't clear existing extension-defined preferences and content settings when reload… (Closed)

Created:
7 years, 3 months ago by Bernhard Bauer
Modified:
7 years, 3 months ago
Reviewers:
falken, Jeffrey Yasskin, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, pam+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Reland r223124: Don't clear existing extension-defined preferences and content settings when reloading or updating an extension. TBR=falken@chromium.org,sky@chromium.org BUG=284385 Original review: https://chromiumcodereview.appspot.com/23694020 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223587

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix #

Messages

Total messages: 6 (0 generated)
Bernhard Bauer
Please review. The CL as originally committed is in patch set 1, for comparison. I ...
7 years, 3 months ago (2013-09-16 22:18:27 UTC) #1
Jeffrey Yasskin
Argh. :( lgtm.
7 years, 3 months ago (2013-09-16 22:40:07 UTC) #2
Bernhard Bauer
Matt, Scott: TBR
7 years, 3 months ago (2013-09-17 07:29:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/23581015/18001
7 years, 3 months ago (2013-09-17 07:29:47 UTC) #4
falken
lgtm
7 years, 3 months ago (2013-09-17 07:41:23 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 12:04:01 UTC) #6
Message was sent while issue was closed.
Change committed as 223587

Powered by Google App Engine
This is Rietveld 408576698