Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 23578042: Enable Device Motion API in Blink by default. (Closed)

Created:
7 years, 3 months ago by timvolodine
Modified:
7 years, 3 months ago
CC:
blink-reviews, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable Device Motion API in Blink by default. We are now ready to enable Device Motion API for all platforms. This patch sets DeviceMotion status to stable. For the corresponding patch to enable Device Motion API on the Chromium side see: https://codereview.chromium.org/24220002/ BUG=135804 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158031

Patch Set 1 #

Patch Set 2 : added DeviceMotionEvent to global-constructors-listing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
timvolodine
7 years, 3 months ago (2013-09-18 17:53:15 UTC) #1
Peter Beverloo
Perhaps refer to the Chromium sided patch?
7 years, 3 months ago (2013-09-18 17:53:49 UTC) #2
timvolodine
On 2013/09/18 17:53:49, Peter Beverloo wrote: > Perhaps refer to the Chromium sided patch? done.
7 years, 3 months ago (2013-09-18 17:55:31 UTC) #3
timvolodine
+ jochen
7 years, 3 months ago (2013-09-19 10:15:04 UTC) #4
timvolodine
+ ping ;), need to land this asap to make the M31 branch point..
7 years, 3 months ago (2013-09-19 10:15:50 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 3 months ago (2013-09-19 12:32:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/23578042/11001
7 years, 3 months ago (2013-09-19 14:05:46 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 15:14:54 UTC) #8
Message was sent while issue was closed.
Change committed as 158031

Powered by Google App Engine
This is Rietveld 408576698