Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 23578030: Reland Handle non-JSObject heap objects using slow-path IC stub guarded by the map. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Reland Handle non-JSObject heap objects using slow-path IC stub guarded by the map. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16696

Patch Set 1 #

Patch Set 2 : Filter non-jsmaps for keyed loads #

Total comments: 2

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -108 lines) Patch
M src/builtins.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 9 chunks +17 lines, -7 lines 0 comments Download
M src/ic.h View 7 chunks +11 lines, -8 lines 0 comments Download
M src/ic.cc View 4 chunks +21 lines, -27 lines 0 comments Download
M src/objects.h View 3 chunks +11 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M src/stub-cache.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/stub-cache.cc View 27 chunks +49 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
7 years, 3 months ago (2013-09-12 17:59:50 UTC) #1
Michael Starzinger
LGTM (only reviewed delta between first and second patch set). https://codereview.chromium.org/23578030/diff/3001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/23578030/diff/3001/src/hydrogen.cc#newcode4625 ...
7 years, 3 months ago (2013-09-12 21:41:38 UTC) #2
Toon Verwaest
Addressed comments. Landing.
7 years, 3 months ago (2013-09-12 22:03:39 UTC) #3
Toon Verwaest
7 years, 3 months ago (2013-09-12 22:04:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r16696 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698