Copy perf_tests_helper.py into build/util/lib

Copy perf_tests_helper.py into build/util/lib

Sorry for the delay on this one. Based off advice in https://codereview.chromium.org/22754003. Just a simple copy of the file, and removing the (seemingly unnecessary?) import of android_commands.

Will remove dependencies on old one as part of above mentioned patch.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223190

[bulach, 2013-09-11 11:41:07]

thanks ryan! this is going in the right direction, I just have some suggestions
to further clarify the dependencies, thanks for making sense of this spaghetti!!
:)

https://codereview.chromium.org/23578019/diff/3001/build/util/lib/common/perf...
File build/util/lib/common/perf_tests_helper.py (right):

https://codereview.chromium.org/23578019/diff/3001/build/util/lib/common/perf...
build/util/lib/common/perf_tests_helper.py:18: from telemetry.page import
result_data_type
can we define the result_data_type here rather than import from telemetry?
otherwise we have the same problem of interdependence.. :)

here's how I think we should do:
- make build/util/lib an entirely self-contained library.. the only "import"
should be for system modules (like re, sys, json, ...).

- change telemetry to reuse this (so there's a one way dependency from telemetry
into build/util/lib/common).

- change android to reuse this.. I'm happy to take this! there'll be also a one
way dependency from android into build/util/lib/common.

- this file could be called "perf_tests_results_helper", and we could remove
some left-over below..

how does that sound?

https://codereview.chromium.org/23578019/diff/3001/build/util/lib/common/perf...
build/util/lib/common/perf_tests_helper.py:159: class CacheControl(object):
could you remove both CacheControl and PerfControl classes please?

[rschoen, 2013-09-12 22:39:04]

Sorry about that, I was a bit tired when I constructed this :) 


> here's how I think we should do:
> - make build/util/lib an entirely self-contained library.. the only "import"
> should be for system modules (like re, sys, json, ...).

Done

> - change telemetry to reuse this (so there's a one way dependency from
telemetry
> into build/util/lib/common).

Will do this in the other patch as the larger refactor.


> - this file could be called "perf_tests_results_helper", and we could remove
> some left-over below..

Done, except telemetry/core/platform/android_platform_backend.py uses
CacheControl and PerfControl... what should be done about this?

[bulach, 2013-09-13 10:31:18]

lgtm, thanks ryan!! just nits below.

as for telemetry/core/platform/android_platform_backend.py:
it already depends on build/android/pylib, which is ok (since that library
doesn't depend on anything else)..

once this lands, I'll go and cleanup build/android/pylib and friends as follows:
- downstream first (our internal repository), make sure it uses this new
build/util for the results printer
- split out CacheControl and PerfControl into their own files and fix up
telemetry/core/platform/android_platform_backend.py
- fix downstream to use the new CacheControl and PerfControl
- yaaay, finally, get rid of build/android/pylib/perf_tests_helper.py :)

thanks for kicking start it, I'm happy to take from here!

https://codereview.chromium.org/23578019/diff/12001/build/util/lib/common/per...
File build/util/lib/common/perf_result_data_type.py (right):

https://codereview.chromium.org/23578019/diff/12001/build/util/lib/common/per...
build/util/lib/common/perf_result_data_type.py:13: 
nit: another \n here and 15 below (i.e., two new lines between toplevels)

https://codereview.chromium.org/23578019/diff/12001/build/util/lib/common/per...
File build/util/lib/common/perf_tests_helper.py (right):

https://codereview.chromium.org/23578019/diff/12001/build/util/lib/common/per...
build/util/lib/common/perf_tests_helper.py:21: 
nit: \n

https://codereview.chromium.org/23578019/diff/12001/build/util/lib/common/per...
build/util/lib/common/perf_tests_helper.py:150: return output
nit: I think this file would be clearer as perf_tests_results_helper.py

[rschoen, 2013-09-13 19:25:04]

Great, thanks. Nits fixed, committing now. I'll get to refactoring telemetry to
rely on this, but I suppose I'm gated on your implementations of CacheControl
and PerfControl so let me know when that patch lands.

Thanks again for your help!

[commit-bot: I haz the power, 2013-09-13 19:27:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rschoen@google.com/23578019/18001

[commit-bot: I haz the power, 2013-09-14 00:53:38]

Change committed as 223190