Make HostDiscardableSharedMemoryManager a client of memory coordinator

Make HostDiscardableSharedMemoryManager a client of memory coordinator

When the memory coordinator is enabled,
HostDiscardableSharedMemoryManager becomes a client of the memory
coordinator instead of installing MemoryPressureListener.

Design Doc: https://docs.google.com/document/d/1a69mMr7jI7qK0OfKNlrZ350xiXizVMCCe8orGX7K8Uo/edit?ts=57d7968b#

BUG=639700
Committed: https://crrev.com/15329677f4aca0761902b0f1513099d58ae1b566
Cr-Commit-Position: refs/heads/master@{#422030}

[hajimehoshi, 2016-09-20 11:11:55]

Patchset #1 (id:1) has been deleted

[hajimehoshi, 2016-09-20 11:12:33]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 11:12:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hajimehoshi, 2016-09-20 11:16:13]

hajimehoshi@chromium.org changed reviewers:
+ avi@chromium.org, bashi@chromium.org, chrisha@chromium.org

[hajimehoshi, 2016-09-20 11:16:13]

PTAL

[commit-bot: I haz the power, 2016-09-20 11:27:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 11:27:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Avi (use Gerrit), 2016-09-20 14:04:02]

lgtm

[bashi, 2016-09-21 00:29:10]

non-owner lgtm

[hajimehoshi, 2016-09-21 02:18:24]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-09-21 02:18:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 02:42:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 02:42:43]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[hajimehoshi, 2016-09-21 04:51:45]

The CQ bit was checked by hajimehoshi@chromium.org

[commit-bot: I haz the power, 2016-09-21 04:51:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 05:27:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 05:27:15]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[hajimehoshi, 2016-09-21 07:33:14]

On 2016/09/21 05:27:15, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Oops, it seems like we can't call FeatureList::IsEnabled before
FeatureList::InitializeInstance.

[hajimehoshi, 2016-09-21 08:57:20]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 08:57:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hajimehoshi, 2016-09-21 08:59:38]

As described above, initialization using base::FeatureList should be delayed
since base::FeatureList is not initialized at this time.
(base::FeatureList::InitializeInstance is called at
BrowserMainLoop::PreCreateThreads and it is assumed that IsEnabled can't be
called before that.) PTAL

[commit-bot: I haz the power, 2016-09-21 10:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 10:15:23]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[hajimehoshi, 2016-09-21 10:56:03]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 10:56:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 12:12:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 12:12:35]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[hajimehoshi, 2016-09-23 06:01:54]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 06:02:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 06:59:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 06:59:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hajimehoshi, 2016-09-23 07:21:32]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 07:21:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 08:46:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 08:46:29]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[hajimehoshi, 2016-09-23 09:29:31]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 09:29:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hajimehoshi, 2016-09-23 09:32:07]

Patchset #5 (id:100001) has been deleted

[hajimehoshi, 2016-09-23 09:32:22]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 09:32:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hajimehoshi, 2016-09-23 09:36:15]

On 2016/09/21 08:59:38, hajimehoshi wrote:
> As described above, initialization using base::FeatureList should be delayed
> since base::FeatureList is not initialized at this time.
> (base::FeatureList::InitializeInstance is called at
> BrowserMainLoop::PreCreateThreads and it is assumed that IsEnabled can't be
> called before that.) PTAL

As we discussed offline, since it is difficult to assure when flags are
available, we changed the policy not to see the flag and register both
MemoryPressureListener and MemoryCoordinatorClient. When MemoryCoordinator is
enabled, we plan to suppress MemoryPressureMonitor so this should work
correctly.

[commit-bot: I haz the power, 2016-09-23 09:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:47:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hajimehoshi, 2016-09-29 07:25:47]

The CQ bit was checked by hajimehoshi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 07:26:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 08:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 08:23:22]

Dry run: This issue passed the CQ dry run.

[hajimehoshi, 2016-09-29 09:02:49]

avi@: The basic concept doesn't change but I have added some small changes to
pass the test bots since your last review.

PTAL

[Avi (use Gerrit), 2016-09-29 13:52:47]

still lgtm

[hajimehoshi, 2016-09-30 04:37:05]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-09-30 04:37:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2357603002/#ps140001
(title: "Remove comments that indicated TODOs in a different component")

[commit-bot: I haz the power, 2016-09-30 04:37:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 04:43:29]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-09-30 04:46:03]

Description was changed from

==========
Make HostDiscardableSharedMemoryManager a client of memory coordinator

When the memory coordinator is enabled,
HostDiscardableSharedMemoryManager becomes a client of the memory
coordinator instead of installing MemoryPressureListener.

Design Doc:
https://docs.google.com/document/d/1a69mMr7jI7qK0OfKNlrZ350xiXizVMCCe8orGX7K8...

BUG=639700
==========

to

==========
Make HostDiscardableSharedMemoryManager a client of memory coordinator

When the memory coordinator is enabled,
HostDiscardableSharedMemoryManager becomes a client of the memory
coordinator instead of installing MemoryPressureListener.

Design Doc:
https://docs.google.com/document/d/1a69mMr7jI7qK0OfKNlrZ350xiXizVMCCe8orGX7K8...

BUG=639700

Committed: https://crrev.com/15329677f4aca0761902b0f1513099d58ae1b566
Cr-Commit-Position: refs/heads/master@{#422030}
==========

[commit-bot: I haz the power, 2016-09-30 04:46:04]

Patchset 6 (id:??) landed as
https://crrev.com/15329677f4aca0761902b0f1513099d58ae1b566
Cr-Commit-Position: refs/heads/master@{#422030}