Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py

Issue 23572025: [telemetry] Add webdriver_ie_backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
diff --git a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
index a66721ac799a5758814eb1cdc2f68b203424dc4b..b9ad45d297921054cd5585077e475189c7b86975 100644
--- a/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
+++ b/tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py
@@ -11,7 +11,7 @@ from telemetry.core import browser
from telemetry.core import possible_browser
from telemetry.core import platform
from telemetry.core import util
-from telemetry.core.backends.webdriver import webdriver_browser_backend
+from telemetry.core.backends.webdriver import webdriver_ie_backend
from telemetry.page import cloud_storage
# Try to import the selenium python lib which may be not available.
@@ -39,12 +39,13 @@ class PossibleWebDriverBrowser(possible_browser.PossibleBrowser):
def __init__(self, browser_type, finder_options):
super(PossibleWebDriverBrowser, self).__init__(browser_type, finder_options)
- def CreateWebDriverBackend(self):
+ def CreateWebDriverBackend(self, platform_backend):
raise NotImplementedError()
def Create(self):
- backend = self.CreateWebDriverBackend()
- b = browser.Browser(backend, platform.CreatePlatformBackendForCurrentOS())
+ platform_backend = platform.CreatePlatformBackendForCurrentOS()
+ backend = self.CreateWebDriverBackend(platform_backend)
+ b = browser.Browser(backend, platform_backend)
return b
def SupportsOptions(self, finder_options):
@@ -61,7 +62,7 @@ class PossibleDesktopIE(PossibleWebDriverBrowser):
super(PossibleDesktopIE, self).__init__(browser_type, finder_options)
self._architecture = architecture
- def CreateWebDriverBackend(self):
+ def CreateWebDriverBackend(self, platform_backend):
assert webdriver
def DriverCreator():
ie_driver_exe = os.path.join(util.GetTelemetryDir(), 'bin',
@@ -69,8 +70,8 @@ class PossibleDesktopIE(PossibleWebDriverBrowser):
cloud_storage.GetIfChanged(cloud_storage.CHROMIUM_TELEMETRY_BUCKET,
ie_driver_exe)
return webdriver.Ie(executable_path=ie_driver_exe)
- return webdriver_browser_backend.WebDriverBrowserBackend(
- DriverCreator, False, self.finder_options)
+ return webdriver_ie_backend.WebDriverIEBackend(
+ platform_backend, DriverCreator, self.finder_options)
def SelectDefaultBrowser(_):
return None

Powered by Google App Engine
This is Rietveld 408576698