Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 23572016: [Android WebView] Wire up the viewport quirks settings (Closed)

Created:
7 years, 3 months ago by mnaganov (inactive)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Wire up the viewport quirks settings Wires up Blink WebSettings introduced in https://codereview.chromium.org/22909031 and then updated in https://codereview.chromium.org/23691017 These quirks are to maintain compatibility with Android apps built on the Android SDK prior to and including version 18. Presumably, this can be removed any time after 2015. BUG=277369, 282130 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221557

Patch Set 1 #

Patch Set 2 : Split into 2 quirks, as per the final version of Blink's http://crrev.com/23691017 #

Messages

Total messages: 12 (0 generated)
mnaganov (inactive)
This assumes Blink's https://codereview.chromium.org/23691017 and Chromium's https://codereview.chromium.org/23483005 landed (both are still under a review, but ...
7 years, 3 months ago (2013-08-30 11:03:52 UTC) #1
benm (inactive)
lgtm
7 years, 3 months ago (2013-08-30 13:05:35 UTC) #2
mnaganov (inactive)
Joth, please take a look just in case.
7 years, 3 months ago (2013-09-05 18:08:51 UTC) #3
joth
lgtm
7 years, 3 months ago (2013-09-05 19:10:52 UTC) #4
mnaganov (inactive)
Need an OWNER's review: jamesr@: content/renderer and webkit/ joi@: content/public
7 years, 3 months ago (2013-09-05 19:16:55 UTC) #5
Jói
//content/public LGTM
7 years, 3 months ago (2013-09-05 19:22:27 UTC) #6
jamesr
What's the path for getting rid of this? I don't see that documented in the ...
7 years, 3 months ago (2013-09-05 21:47:24 UTC) #7
mnaganov (inactive)
On 2013/09/05 21:47:24, jamesr wrote: > What's the path for getting rid of this? I ...
7 years, 3 months ago (2013-09-05 21:54:29 UTC) #8
jamesr
Put that in the patch description too, then. code lgtm
7 years, 3 months ago (2013-09-05 21:56:41 UTC) #9
mnaganov (inactive)
On 2013/09/05 21:56:41, jamesr wrote: > Put that in the patch description too, then. > ...
7 years, 3 months ago (2013-09-05 22:00:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/23572016/4001
7 years, 3 months ago (2013-09-05 22:01:37 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 01:24:49 UTC) #12
Message was sent while issue was closed.
Change committed as 221557

Powered by Google App Engine
This is Rietveld 408576698