Issue 23570009: bookmarks: Cleanup, remove BookmarkModelTestUtils class.

Issue 23570009: bookmarks: Cleanup, remove BookmarkModelTestUtils class. (Closed)

Created:
7 years, 3 months ago by tfarina

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

bookmarks: Cleanup, remove BookmarkModelTestUtils class. As earlier refactorings made possible, this moves the remaining functions from BookmarkModelTestUtils class into bookmark_test_helpers.h file. BUG=None TEST=unit_tests R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223299

Patch Set 1 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+189 lines, -246 lines)			Patch
D	chrome/browser/bookmarks/bookmark_model_test_utils.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/bookmarks/bookmark_model_test_utils.cc	View	1 chunk	+0 lines, -88 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model_unittest.cc	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_test_helpers.h	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_test_helpers.cc	View	3 chunks	+72 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm	View	16 chunks	+29 lines, -35 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm	View	29 chunks	+50 lines, -61 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23570009/2001

7 years, 3 months ago (2013-09-15 06:09:06 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=79104

7 years, 3 months ago (2013-09-15 16:08:27 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/23570009/2001

7 years, 3 months ago (2013-09-15 20:26:12 UTC) #5

Message was sent while issue was closed.

Change committed as 223299

Expand Messages | Collapse Messages