Issue 23569008: Never decode the favicon in FaviconUtil::SelectFaviconFramesFromPNGs() when the desired size is 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23569008: Never decode the favicon in FaviconUtil::SelectFaviconFramesFromPNGs() when the desired size is 0 (Closed)

Created:
7 years, 3 months ago by pkotwicz

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Never decode the favicon in FaviconUtil::SelectFaviconFramesFromPNGs() to SkBitmap when the desired size is 0. The decoding is unnecessary. Giving the largest PNG a scale factor of 100P matches the behavior in SelectFaviconFrames(). This is a corner case that I need to fix in order fix 278457 BUG=278457 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222070

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/favicon/favicon_util.cc	View		3 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/23569008/1

7 years, 3 months ago (2013-09-09 16:51:56 UTC) #3

Message was sent while issue was closed.

Change committed as 222070

Expand Messages | Collapse Messages