Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23567023: Enable Device Discovery by default on Linux, ChromeOS and Windows. (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 3 months ago
Reviewers:
Lei Zhang, Noam Samuel, gene
CC:
chromium-reviews
Visibility:
Public.

Description

Enable Device Discovery by default on Linux, ChromeOS and Windows. Replace --enable-device-discovery flags with --disable-device-discovery. BUG=286157 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221960

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -26 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications_factory.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications_factory.cc View 1 2 3 4 5 6 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-06 23:33:47 UTC) #1
Noam Samuel
lgtm
7 years, 3 months ago (2013-09-06 23:40:22 UTC) #2
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-06 23:45:18 UTC) #3
Noam Samuel
On 2013/09/06 23:45:18, Vitaly Buka wrote: lgtm++
7 years, 3 months ago (2013-09-06 23:48:40 UTC) #4
Noam Samuel
On 2013/09/06 23:45:18, Vitaly Buka wrote: lgtm++
7 years, 3 months ago (2013-09-06 23:48:41 UTC) #5
Lei Zhang
lgtm https://codereview.chromium.org/23567023/diff/8001/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/23567023/diff/8001/chrome/common/chrome_switches.cc#newcode559 chrome/common/chrome_switches.cc:559: // Disables device discovery. nit: keep this in ...
7 years, 3 months ago (2013-09-06 23:50:01 UTC) #6
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/23567023/diff/8001/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/23567023/diff/8001/chrome/common/chrome_switches.cc#newcode559 chrome/common/chrome_switches.cc:559: // Disables device discovery. On 2013/09/06 23:50:01, Lei Zhang ...
7 years, 3 months ago (2013-09-06 23:53:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23567023/34001
7 years, 3 months ago (2013-09-07 04:46:43 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=166091
7 years, 3 months ago (2013-09-07 05:44:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23567023/34001
7 years, 3 months ago (2013-09-07 05:56:38 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=166095
7 years, 3 months ago (2013-09-07 07:14:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23567023/34001
7 years, 3 months ago (2013-09-07 07:38:58 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=166107
7 years, 3 months ago (2013-09-07 08:56:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23567023/34001
7 years, 3 months ago (2013-09-07 15:57:47 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=152406
7 years, 3 months ago (2013-09-07 16:52:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23567023/34001
7 years, 3 months ago (2013-09-07 18:04:37 UTC) #16
Vitaly Buka (NO REVIEWS)
On 2013/09/07 18:04:37, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 3 months ago (2013-09-07 18:11:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23567023/103001
7 years, 3 months ago (2013-09-08 07:42:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23567023/26010
7 years, 3 months ago (2013-09-08 10:01:48 UTC) #19
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=76600
7 years, 3 months ago (2013-09-08 19:27:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23567023/26010
7 years, 3 months ago (2013-09-08 20:18:29 UTC) #21
commit-bot: I haz the power
7 years, 3 months ago (2013-09-08 23:45:07 UTC) #22
Message was sent while issue was closed. 
Change committed as 221960

Powered by Google App Engine
This is Rietveld 408576698